Repository navigation
Commit 3af4696
* fix(web): async dynamic() serializes its landing and the client adopts it (#3666)
dynamic() no longer opts its memo out of hydration serialization. The
factory memo boxes a thenable the source returns so it stays sync-valued
(hoisted factories have no id); the per-instance value memo unboxes it and
is an ordinary async memo — its landing serializes under the instance id
and the client memo adopts the record during hydration instead of
re-running the source and waiting on it, the pending beat that committed
the enclosing <Loading> to a fallback the server never rendered.
- Server component landings cross as flight references; `_$SC.r(id,
address)` now resolves to the call's COMPONENT_BINDING so the adopted
value passes `sameInstance` and mounts carry the address. Any async
wrapper around a server reference (router query(), an async arrow)
hydrates the same as a direct call.
- A client component function landing cannot cross: new diagnostic
DYNAMIC_ASYNC_COMPONENT — recorded on the observe channel, the memo
rejects in every tier (dev with guidance, prod with the code).
- deferStream still holds the shell for both source-async (the value memo's
option) and dependency-async (the block on a NotReady the source threw).
- Sync sources unchanged: no record is written.
Wire shape: one hydration record per async dynamic() instance; one more
hydration owner id per dynamic() instance. Artifacts re-recorded where the
spec is the recorder; the 8 specs that resolved async sources to client
component functions are rewritten to server components / tag names.
Co-authored-by: Claude <[email protected]>
Agent: Claude via Cursor
Co-authored-by: Cursor <[email protected]>
* chore(size): ratchet CSR app and frames eager consumer for #3671
CSR app 15.99 -> 16.04 KB: measured 16,025 B against next's 15,967 (+58 B,
35 B over). Brotli layout drift — the scenario never imports dynamic(),
the minified bundle is 45,297 B on both sides and differs only in esbuild's
short-name assignment.
Frames eager consumer 12.40 -> 12.42 KB: measured 12,410 B against next's
12,367 (+43 B, 10 B over). +98 B minified in the frames client's fallback
_$SC bootstrap, which now mints address-bound COMPONENT_BINDING bindings.
Co-authored-by: Claude <[email protected]>
Agent: Claude via Cursor
Co-authored-by: Cursor <[email protected]>
---------
Co-authored-by: Claude <[email protected]>
Co-authored-by: Cursor <[email protected]>
1 parent 1a7d14f commit 3af4696
44 files changed
Lines changed: 1385 additions & 191 deletions
File tree
- .changeset
- documentation/solid-2.0
- packages
- signals/src/core
- solid
- skills/reactivity-diagnostics
- src
- client
- server
- web
- frames/src
- src
- test
- harness
- __artifacts__
- hydration
- server
- scripts/size
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
202 | | - | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
203 | 221 | | |
204 | 222 | | |
205 | 223 | | |
206 | 224 | | |
207 | | - | |
| 225 | + | |
208 | 226 | | |
209 | 227 | | |
210 | 228 | | |
| |||
0 commit comments