|
| 1 | +/** |
| 2 | + * #4354: `<Show when={open()}>{v => …}</Show>` beside a `<Loading>` over an |
| 3 | + * async memo that re-asks on `open`. A write to `open` is held by that memo's |
| 4 | + * flight, so the screen keeps the old branch while Show's selection has |
| 5 | + * already re-run in the held world. An unrelated write (`setFmt`) then re-runs |
| 6 | + * an on-screen binding. A binding is a frame reader: it reads what the screen |
| 7 | + * shows, so the narrowed accessor must not judge the branch stale from the |
| 8 | + * held selection — <Switch>/<Match> already behaves this way. A read after the |
| 9 | + * branch really unmounts still throws (#3948's guard). |
| 10 | + */ |
| 11 | +import { afterEach, expect, test, vi } from "vitest"; |
| 12 | +import { |
| 13 | + createLoadingBoundary, |
| 14 | + createMemo, |
| 15 | + createRenderEffect, |
| 16 | + createRoot, |
| 17 | + createSignal, |
| 18 | + flush, |
| 19 | + Match, |
| 20 | + resetErrorHalt, |
| 21 | + Show, |
| 22 | + Switch |
| 23 | +} from "../src/index.js"; |
| 24 | + |
| 25 | +afterEach(() => { |
| 26 | + resetErrorHalt(); |
| 27 | + vi.restoreAllMocks(); |
| 28 | +}); |
| 29 | + |
| 30 | +const settle = async () => { |
| 31 | + for (let i = 0; i < 3; i++) { |
| 32 | + await Promise.resolve(); |
| 33 | + flush(); |
| 34 | + } |
| 35 | +}; |
| 36 | + |
| 37 | +type Kind = "Show" | "Switch"; |
| 38 | + |
| 39 | +function setup(kind: Kind, keyed: boolean, initial: boolean) { |
| 40 | + const [open, setOpen] = createSignal(initial); |
| 41 | + const [fmt, setFmt] = createSignal("ru"); |
| 42 | + const resolvers: (() => void)[] = []; |
| 43 | + const screen: Record<string, unknown> = {}; |
| 44 | + let accessor: (() => string) | undefined; |
| 45 | + createRoot(() => { |
| 46 | + const data = createMemo(() => { |
| 47 | + const o = open(); |
| 48 | + return new Promise<string>(r => resolvers.push(() => r(`data-${o}`))); |
| 49 | + }); |
| 50 | + const when = () => open() && "sel"; |
| 51 | + const child = (v: string | (() => string)) => { |
| 52 | + const read = typeof v === "function" ? ((accessor = v), v) : () => v; |
| 53 | + createRenderEffect( |
| 54 | + () => `${fmt()}:${read()}`, |
| 55 | + t => void (screen.p = t) |
| 56 | + ); |
| 57 | + return "branch"; |
| 58 | + }; |
| 59 | + const fallback = () => { |
| 60 | + createRenderEffect( |
| 61 | + () => `${fmt()}:closed`, |
| 62 | + t => void (screen.f = t) |
| 63 | + ); |
| 64 | + return "closed"; |
| 65 | + }; |
| 66 | + const view = |
| 67 | + kind === "Show" |
| 68 | + ? Show({ |
| 69 | + get when() { |
| 70 | + return when(); |
| 71 | + }, |
| 72 | + keyed, |
| 73 | + get fallback() { |
| 74 | + return fallback(); |
| 75 | + }, |
| 76 | + children: child |
| 77 | + } as any) |
| 78 | + : Switch({ |
| 79 | + get fallback() { |
| 80 | + return fallback(); |
| 81 | + }, |
| 82 | + get children() { |
| 83 | + return Match({ |
| 84 | + get when() { |
| 85 | + return when(); |
| 86 | + }, |
| 87 | + keyed, |
| 88 | + children: child |
| 89 | + } as any) as any; |
| 90 | + } |
| 91 | + }); |
| 92 | + createRenderEffect( |
| 93 | + () => (view as any)(), |
| 94 | + v => void (screen.view = v) |
| 95 | + ); |
| 96 | + createRenderEffect( |
| 97 | + createLoadingBoundary( |
| 98 | + () => data(), |
| 99 | + () => "wait" |
| 100 | + ), |
| 101 | + v => void (screen.data = v) |
| 102 | + ); |
| 103 | + }); |
| 104 | + return { screen, resolvers, setOpen, setFmt, accessor: () => accessor }; |
| 105 | +} |
| 106 | + |
| 107 | +for (const kind of ["Show", "Switch"] as const) |
| 108 | + for (const keyed of [false, true]) { |
| 109 | + const name = `${kind}${keyed ? " keyed" : ""}`; |
| 110 | + |
| 111 | + test(`${name}: an on-screen branch re-run during the hold that closes it does not halt`, async () => { |
| 112 | + const error = vi.spyOn(console, "error").mockImplementation(() => {}); |
| 113 | + const { screen, resolvers, setOpen, setFmt, accessor } = setup(kind, keyed, true); |
| 114 | + flush(); |
| 115 | + resolvers.shift()!(); |
| 116 | + await settle(); |
| 117 | + expect(screen).toEqual({ view: "branch", p: "ru:sel", data: "data-true" }); |
| 118 | + |
| 119 | + setOpen(false); // held by data's re-ask: the branch stays on screen |
| 120 | + flush(); |
| 121 | + expect(screen).toMatchObject({ view: "branch", p: "ru:sel", data: "data-true" }); |
| 122 | + |
| 123 | + setFmt("en"); // unrelated write re-runs the on-screen binding mid-hold |
| 124 | + flush(); |
| 125 | + expect(screen).toMatchObject({ view: "branch", p: "en:sel", data: "data-true" }); |
| 126 | + |
| 127 | + resolvers.shift()!(); |
| 128 | + await settle(); |
| 129 | + expect(screen).toEqual({ view: "closed", p: "en:sel", f: "en:closed", data: "data-false" }); |
| 130 | + expect(error.mock.calls.map(c => String(c[0]).split("\n")[0])).toEqual([]); |
| 131 | + |
| 132 | + // After the close lands, a read of the narrowed accessor is a real |
| 133 | + // stale read and still throws. |
| 134 | + if (!keyed) expect(() => accessor()!()).toThrow(kind === "Show" ? /<Show>/ : /<Match>/); |
| 135 | + }); |
| 136 | + |
| 137 | + test(`${name}: the fallback re-run during the hold that opens the branch does not halt`, async () => { |
| 138 | + const error = vi.spyOn(console, "error").mockImplementation(() => {}); |
| 139 | + const { screen, resolvers, setOpen, setFmt } = setup(kind, keyed, false); |
| 140 | + flush(); |
| 141 | + resolvers.shift()!(); |
| 142 | + await settle(); |
| 143 | + expect(screen).toEqual({ view: "closed", f: "ru:closed", data: "data-false" }); |
| 144 | + |
| 145 | + setOpen(true); // held: the fallback stays on screen |
| 146 | + flush(); |
| 147 | + expect(screen.view).toBe("closed"); |
| 148 | + expect(screen.data).toBe("data-false"); |
| 149 | + |
| 150 | + setFmt("en"); |
| 151 | + flush(); |
| 152 | + expect(screen.view).toBe("closed"); |
| 153 | + expect(screen.f).toBe("en:closed"); |
| 154 | + |
| 155 | + resolvers.shift()!(); |
| 156 | + await settle(); |
| 157 | + expect(screen.view).toBe("branch"); |
| 158 | + expect(screen.p).toBe("en:sel"); |
| 159 | + expect(screen.data).toBe("data-true"); |
| 160 | + expect(error.mock.calls.map(c => String(c[0]).split("\n")[0])).toEqual([]); |
| 161 | + }); |
| 162 | + } |
| 163 | + |
| 164 | +test("Show: a branch closed and reopened inside one hold keeps reading the screen", async () => { |
| 165 | + const error = vi.spyOn(console, "error").mockImplementation(() => {}); |
| 166 | + const [open, setOpen] = createSignal<string | false>("a"); |
| 167 | + const [fmt, setFmt] = createSignal("ru"); |
| 168 | + const resolvers: (() => void)[] = []; |
| 169 | + const out: string[] = []; |
| 170 | + createRoot(() => { |
| 171 | + const data = createMemo(() => { |
| 172 | + const o = open(); |
| 173 | + return new Promise<string>(r => resolvers.push(() => r(`data-${o}`))); |
| 174 | + }); |
| 175 | + const view = Show({ |
| 176 | + get when() { |
| 177 | + return open(); |
| 178 | + }, |
| 179 | + fallback: "closed", |
| 180 | + children: (v: () => string) => { |
| 181 | + createRenderEffect( |
| 182 | + () => `${fmt()}:${v()}`, |
| 183 | + t => void out.push(t) |
| 184 | + ); |
| 185 | + return "branch"; |
| 186 | + } |
| 187 | + }); |
| 188 | + createRenderEffect( |
| 189 | + () => (view as any)(), |
| 190 | + () => {} |
| 191 | + ); |
| 192 | + createRenderEffect( |
| 193 | + createLoadingBoundary( |
| 194 | + () => data(), |
| 195 | + () => "wait" |
| 196 | + ), |
| 197 | + () => {} |
| 198 | + ); |
| 199 | + }); |
| 200 | + flush(); |
| 201 | + resolvers.shift()!(); |
| 202 | + await settle(); |
| 203 | + setOpen(false); |
| 204 | + flush(); |
| 205 | + setFmt("en"); |
| 206 | + flush(); |
| 207 | + setOpen("b"); |
| 208 | + flush(); |
| 209 | + setFmt("fr"); |
| 210 | + flush(); |
| 211 | + expect(out).toEqual(["ru:a", "en:a", "fr:a"]); |
| 212 | + while (resolvers.length) resolvers.shift()!(); |
| 213 | + await settle(); |
| 214 | + expect(out).toEqual(["ru:a", "en:a", "fr:a", "fr:b"]); |
| 215 | + expect(error.mock.calls.map(c => String(c[0]).split("\n")[0])).toEqual([]); |
| 216 | +}); |
0 commit comments