Skip to content

Commit 23160e6

Browse files
ryansolidClaude via Cursorcursoragent
committed
signals: S1 M4 deletion — reruns lane carve-out for REACTIVE_FRAME_READ
The seat's MARK_ST side effect re-raises the frame mark on the re-read when the flight is still up, so the mark need not be carried across a lane's re-run. Probe: the carve-out still retained the mark 141× in the signals suite; clearing it unconditionally changes no result (signals, solid, web, generator 2k × 3 seeds, shadow 0 classes). −7 B in every scenario, floor included. Co-authored-by: Claude via Cursor <[email protected]> Co-authored-by: Cursor <[email protected]>
1 parent 5ea7d89 commit 23160e6

2 files changed

Lines changed: 11 additions & 5 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@solidjs/signals": patch
3+
---
4+
5+
Reader seat S1 (M4 deletion): `reruns` no longer carries `REACTIVE_FRAME_READ` across a lane's re-run — the seat's MARK_ST side effect re-raises it on the re-read when the flight is still up (#4397 covered by the table).

‎packages/signals/src/core/scheduler.ts‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1288,11 +1288,12 @@ export function reruns(u: Transaction): unknown {
12881288
// frame about to replace it (#4407; #4284: the grouping never changes
12891289
// the screen).
12901290
frame ||= (r as any)._type || s === r;
1291-
// A lane's reveal leaves the mark to the transaction: a reader that
1292-
// also read a held node as committed (`staleReader`) still observes
1293-
// that flight until it re-runs — cleared here, the transaction landed
1294-
// at this seam with the flight up and voided the reveal's run (#4397).
1295-
if (!u._lane) r._flags &= ~REACTIVE_FRAME_READ;
1291+
// The frame mark is the seat's to re-raise: a reader that also read a
1292+
// held node as committed (`staleReader`) re-reads it on this run and
1293+
// the slot's side effect (MARK_ST) marks it again if the flight is
1294+
// still up (#4397) — a lane's reveal no longer needs the mark carried
1295+
// across the re-run.
1296+
r._flags &= ~REACTIVE_FRAME_READ;
12961297
(r as any)._modified = false;
12971298
// Its frame is replaced by the re-derivation: a run one of its
12981299
// children queued this flush (re-run by the same landing) is for the

0 commit comments

Comments
 (0)