|
| 1 | +/** |
| 2 | + * @jsxImportSource @solidjs/web |
| 3 | + * @vitest-environment jsdom |
| 4 | + */ |
| 5 | +/** |
| 6 | + * A shared render effect must not pair the held filter change with a guess |
| 7 | + * over the previous answer. Separate bindings are covered by #4525. |
| 8 | + */ |
| 9 | +import { expect, test } from "vitest"; |
| 10 | +import { |
| 11 | + Loading, |
| 12 | + action, |
| 13 | + createMemo, |
| 14 | + createOptimisticStore, |
| 15 | + createSignal, |
| 16 | + flush, |
| 17 | + refresh |
| 18 | +} from "solid-js"; |
| 19 | +import { render } from "../src/index.js"; |
| 20 | + |
| 21 | +const tick = async () => { |
| 22 | + for (let i = 0; i < 4; i++) { |
| 23 | + await new Promise(r => setTimeout(r, 0)); |
| 24 | + flush(); |
| 25 | + } |
| 26 | +}; |
| 27 | + |
| 28 | +for (const on of [true, false]) |
| 29 | + for (const order of ["question first", "list first"] as const) |
| 30 | + for (const mode of ["inline", "memo"] as const) |
| 31 | + test(`#4536: a single render effect keeps the question and optimistic rows in one world (on=${on}, ${order}, ${mode})`, async () => { |
| 32 | + const asks: { key: string; res: (v: any) => void }[] = []; |
| 33 | + const ask = (key: string) => new Promise<any>(res => asks.push({ key, res })); |
| 34 | + const settle = async (key: string, v: any) => { |
| 35 | + const i = asks.findIndex(a => a.key === key); |
| 36 | + expect(i).toBeGreaterThanOrEqual(0); |
| 37 | + asks.splice(i, 1)[0].res(v); |
| 38 | + await tick(); |
| 39 | + }; |
| 40 | + const container = document.body.appendChild(document.createElement("div")); |
| 41 | + // Every DOM state the screen passes through. |
| 42 | + const seen: string[] = []; |
| 43 | + const observer = new MutationObserver(() => seen.push(container.textContent!)); |
| 44 | + observer.observe(container, { childList: true, subtree: true, characterData: true }); |
| 45 | + let setFilter!: (f: string) => void; |
| 46 | + let closeOne!: (id: number) => any; |
| 47 | + const dispose = render(() => { |
| 48 | + const [filter, sf] = createSignal("open"); |
| 49 | + setFilter = sf; |
| 50 | + const [issues, set] = createOptimisticStore<any[]>(() => ask(`issues:${filter()}`), [], { |
| 51 | + key: "id" |
| 52 | + }); |
| 53 | + closeOne = action(function* (id: number) { |
| 54 | + set(list => { |
| 55 | + const i = list.findIndex(t => t.id === id); |
| 56 | + if (i >= 0) list.splice(i, 1); |
| 57 | + }); |
| 58 | + yield ask(`close:${id}`); |
| 59 | + refresh(issues); |
| 60 | + }); |
| 61 | + const screen = () => { |
| 62 | + let question: string; |
| 63 | + let rows: string; |
| 64 | + if (order === "question first") { |
| 65 | + question = filter(); |
| 66 | + rows = issues.map(it => `[#${it.id}]`).join(""); |
| 67 | + } else { |
| 68 | + rows = issues.map(it => `[#${it.id}]`).join(""); |
| 69 | + question = filter(); |
| 70 | + } |
| 71 | + return `${question}: ${rows}`; |
| 72 | + }; |
| 73 | + const body = () => { |
| 74 | + const value = mode === "memo" ? createMemo(screen) : screen; |
| 75 | + return <p>{value()}</p>; |
| 76 | + }; |
| 77 | + return on ? ( |
| 78 | + <Loading on={filter()} fallback={<p>loading</p>}> |
| 79 | + {body()} |
| 80 | + </Loading> |
| 81 | + ) : ( |
| 82 | + <Loading fallback={<p>loading</p>}>{body()}</Loading> |
| 83 | + ); |
| 84 | + }, container); |
| 85 | + try { |
| 86 | + await tick(); |
| 87 | + await settle("issues:open", [{ id: 1 }, { id: 3 }, { id: 4 }]); |
| 88 | + expect(container.textContent).toBe("open: [#1][#3][#4]"); |
| 89 | + setFilter("closed"); |
| 90 | + await tick(); |
| 91 | + expect(container.textContent).toBe(on ? "loading" : "open: [#1][#3][#4]"); |
| 92 | + closeOne(1); |
| 93 | + await tick(); |
| 94 | + // A reset boundary stays in fallback; otherwise the guess may wait |
| 95 | + // with the pending read or show over the held open answer. |
| 96 | + expect(on ? ["loading"] : ["open: [#3][#4]", "open: [#1][#3][#4]"]).toContain( |
| 97 | + container.textContent |
| 98 | + ); |
| 99 | + await settle("issues:closed", [{ id: 1 }, { id: 2 }]); |
| 100 | + expect(container.textContent).toBe("closed: [#2]"); |
| 101 | + await settle("close:1", {}); |
| 102 | + expect(container.textContent).toBe("closed: [#2]"); |
| 103 | + await settle("issues:closed", [{ id: 2 }]); |
| 104 | + expect(container.textContent).toBe("closed: [#2]"); |
| 105 | + expect(asks).toEqual([]); |
| 106 | + // Never a row of the open list beside `closed` (F-1). |
| 107 | + expect(seen.filter(s => s.startsWith("closed") && /#3|#4/.test(s))).toEqual([]); |
| 108 | + } finally { |
| 109 | + observer.disconnect(); |
| 110 | + dispose(); |
| 111 | + container.remove(); |
| 112 | + } |
| 113 | + }); |
0 commit comments