You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 11d4c93
Browse filesBrowse the repository at this point in the historyBrowse files
committed
fix(refresh): keep the HMR wrapper out of owner paths
The solid-js/refresh proxy wraps every component body in a memo so a
module swap re-runs it in place. That memo was named `[solid-refresh]App`,
so it sat between the component's dev root and the body in every owner
path — `<App> › [solid-refresh]App › <Router>` on the Performance panel,
in diagnostic findings and in captures. Two nodes are needed (a root for
identity, a memo to re-run); two names are not. The memo is now nameless
(`""` — an omitted name is labelled "computed"), which `ownerPath` skips.
The proxy also reports the component's own name, so a createComponent the
compiler did not label opens a `<App>` root rather than `<[solid-refresh]App>`.
Co-authored-by: Claude via Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
The `solid-js/refresh` HMR wrapper no longer appears in owner paths. Its memo is nameless, so a component reads as `<App> › <Router>` in performance-track labels, diagnostic findings and captures rather than `<App> › [solid-refresh]App › <Router>`; the proxy also carries the component's own name, so an unlabelled `createComponent` opens a `<App>` root rather than `<[solid-refresh]App>`.
0 commit comments