Repository navigation
Commit 02b52b5
* fix(web): a hydrating hole holding a raw string re-claims its region (#4374)
A `<Loading>` with a bare-string fallback, the sole content of a
markerless parent, leaves the hole's `current` as that string after the
root pass. `reclaimRegion` bailed for non-node currents, so after the
streamed `$df` swap the content pass reconciled against the stale string:
the server's text stayed beside a fresh copy (a nested Errored's fallback
rendered twice), or text after an element moved or was replaced instead
of adopted. While hydrating, a disconnected-or-primitive `current` now
re-claims the region, as it does when the nodes it tracks are gone.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* fix(web): a sole text child's update inserts when the document removed its node (#4372)
An Errored outside a streamed Loading whose fragment rejects: the client
hydrated the shell, so the root insert tracked the claimed fallback's
text ("[LOAD]") as a sole text child. The fragment's swap replaced that
node, and the rejected fragment's fresh render cleared what the swap put
in, so the Errored's fallback text was written to `parent.firstChild`,
which was null: TypeError, REACTIVITY_HALTED, an empty <main>. The text
fast path now needs that node to exist; with none, the value is inserted
like a first one, as the element path already does.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* fix(solid): a rejected fragment's clear gives an emptied region its text node back (#4372)
Moves the #4372 fix off `insertExpression`'s hot text path, which every
app ships, to the cold path that breaks its assumption. A streamed
Loading whose fallback an insert claimed as its sole text child: the
fragment's swap takes that text node with the placeholder range, and the
rejected fragment's fresh render clears what the swap put in, leaving the
region empty. The next text value (an outer Errored's fallback, or text
the content renders fresh) was then written to a missing first child.
The clear now leaves an emptied region an empty text node, which that
write fills. The insert fast path is back as it was on next; the
hand-removal spec is pinned as a known failure. Adds the `text` shape:
an empty rejected template under no Errored, the same crash on next.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* fix(solid): golf the #4372 clear; record its hydrating scenarios over next
A `placeholder(id)` helper serves the region capture and the two
existing `pl-*` lookups, so the fix costs +42 B minified in hydrating
bundles (from +85 B) and 0 B in every CSR scenario and the non-hydrating
floors. The three scenarios that sat at their recorded minified get a
dated ledger line.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* fix(web): a falsy primitive fallback (0) re-claims its region too (#4374)
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* test(web): #4372 pins only; the fix is #4382's region re-claim
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
---------
Co-authored-by: Claude <[email protected]>
1 parent 56eb192 commit 02b52b5
9 files changed
Lines changed: 272 additions & 1 deletion
File tree
- packages/web/test
- harness
- __artifacts__
- hydration
- server
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3196 | 3196 | | |
3197 | 3197 | | |
3198 | 3198 | | |
| 3199 | + | |
| 3200 | + | |
| 3201 | + | |
| 3202 | + | |
| 3203 | + | |
| 3204 | + | |
| 3205 | + | |
| 3206 | + | |
| 3207 | + | |
| 3208 | + | |
| 3209 | + | |
| 3210 | + | |
| 3211 | + | |
| 3212 | + | |
| 3213 | + | |
| 3214 | + | |
| 3215 | + | |
| 3216 | + | |
| 3217 | + | |
| 3218 | + | |
| 3219 | + | |
| 3220 | + | |
| 3221 | + | |
| 3222 | + | |
| 3223 | + | |
| 3224 | + | |
| 3225 | + | |
| 3226 | + | |
| 3227 | + | |
| 3228 | + | |
| 3229 | + | |
| 3230 | + | |
| 3231 | + | |
| 3232 | + | |
| 3233 | + | |
| 3234 | + | |
| 3235 | + | |
| 3236 | + | |
| 3237 | + | |
| 3238 | + | |
| 3239 | + | |
| 3240 | + | |
| 3241 | + | |
| 3242 | + | |
| 3243 | + | |
| 3244 | + | |
| 3245 | + | |
| 3246 | + | |
| 3247 | + | |
| 3248 | + | |
| 3249 | + | |
| 3250 | + | |
| 3251 | + | |
| 3252 | + | |
| 3253 | + | |
| 3254 | + | |
| 3255 | + | |
| 3256 | + | |
| 3257 | + | |
| 3258 | + | |
| 3259 | + | |
| 3260 | + | |
| 3261 | + | |
| 3262 | + | |
| 3263 | + | |
| 3264 | + | |
| 3265 | + | |
| 3266 | + | |
| 3267 | + | |
| 3268 | + | |
| 3269 | + | |
| 3270 | + | |
| 3271 | + | |
| 3272 | + | |
| 3273 | + | |
3199 | 3274 | | |
3200 | 3275 | | |
3201 | 3276 | | |
| |||
0 commit comments