|
| 1 | +# Reader seat: the work, after the rulings review (2026-10-28) |
| 2 | + |
| 3 | +Date: 2026-10-28. `next` @ `bc6377c19`. This is the brief every thread on |
| 4 | +the async core works from. It supersedes the ruling list (§5) of the |
| 5 | +reader-seat carve design; the design's model (§2) and table (§2.5) stand with |
| 6 | +the changes in §4 below. Rules live in `packages/signals/docs/`; this file |
| 7 | +cites them and does not restate them. |
| 8 | + |
| 9 | +## 1. What the review found |
| 10 | + |
| 11 | +The design asked eight rulings. Read one at a time against |
| 12 | +`RULES-FUNDAMENTALS.md` and `RULES-DERIVED.md`: |
| 13 | + |
| 14 | +- Six were already ruled. In three the code contradicts the rule (R2, R5, |
| 15 | + R7); in one a doc gloss misled (R3); in one a rule for optimistic lanes was |
| 16 | + never applied to verdict lanes (R4); one is D-2 as written (R6). |
| 17 | +- Two were decided today (R1's scope, R8). |
| 18 | +- One rule that was questioned, D-27, stands — and the reason it stands is |
| 19 | + now written down. |
| 20 | + |
| 21 | +The pattern is the finding: the verdict path has drifted from the rules in |
| 22 | +several places at once, and each drift was found by a generator case. That is |
| 23 | +the case for the carve. It also makes P0 larger than the design priced. |
| 24 | + |
| 25 | +| ruling | outcome | rule | where it is written | |
| 26 | +| ------ | --------------------------------------------------------------------------------- | ------------------------- | ------------------------------------- | |
| 27 | +| R1 | both orders show `[committed, true]`; not for the hold's own work | A10, D-25, D-27, #3884 | D-25 (clarified 2026-10-28) | |
| 28 | +| R2 | the parent waits for a lane's flights; the lane never waits for the parent | F-6, F-1, F-3, 2026-10-01 | F-6 (amended 2026-10-28, `d1b938d3c`) | |
| 29 | +| R3 | an untracked read of a live guess sees the guess, lane held or not | F-11, A17 | F-1 gloss (clarified, `40cde2cd6`) | |
| 30 | +| R4 | a pass reading two holds' display-ahead values is one reveal unit | A15 #3335 | D-25 | |
| 31 | +| R5 | `latest()` opens no hold; the pass re-derives once at a park | F-10, D-2, A10 | D-22 | |
| 32 | +| R6 | E8 is an equivalence for render effects only | D-2, F-9 | no change | |
| 33 | +| R7 | `v:0 l:1` through a memo as inline; verdict work shows the screen for plain reads | F-6, D-25, D-26 | D-26, A15 note | |
| 34 | +| R8 | `latest()` of a held first answer reveals; the plain read still throws | D-22, F-9, S-40 | D-22, S-45 | |
| 35 | +| D-27 | stands: a verdict mount is mainline; a plain read is never display-ahead | F-6, F-11 | D-27, Lane vocabulary | |
| 36 | + |
| 37 | +Every thread on this area reads, before anything else: the precedence rule |
| 38 | +at the top of `RULES-FUNDAMENTALS.md` (a fundamental beats a derived rule |
| 39 | +beats the archive; when code and a fundamental disagree, that is a finding |
| 40 | +for the maintainer, not a ruling to pick), D-27's clarification (why the |
| 41 | +fallback appears, and that it is correct), and discussion |
| 42 | +[#3905](https://github.com/solidjs/solid/discussions/3905) (overlap means |
| 43 | +merge; a node has one pending version; the escape hatches are `latest()` at |
| 44 | +the read and `onFlush` at the write — not a new row in the slot table). |
| 45 | + |
| 46 | +## 2. Bugs on `next` (P0a) |
| 47 | + |
| 48 | +Each is one PR, one worktree, no shared git store, merged serially onto |
| 49 | +`next` with a rebase. Each fix is minimal and correct; **no golfing** — the |
| 50 | +carve deletes the code these fixes land in and pays the bytes back. Each pin |
| 51 | +names its rule and, where the design has one, its seat row. |
| 52 | + |
| 53 | +| # | shape | seam | rule | row | |
| 54 | +| --- | ------------------------------------------------------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | --------------- | ------- | |
| 55 | +| R5 | #4365: `latest(a) + b()` in a plain flush computes `a` new beside `b` old; a throw sticks | `verdict.ts` `provisionalVerdict`, the `!probing` arm: drop `joinFuture(null)`, go through `watchVerdict`. Not at `stagedScreen`. Vl1 and Vl3 untouched | D-22, F-10, D-2 | Vl2, W | |
| 56 | +| R7 | `[s(), L()]`, `L = memo(latest(s))`, shows `v:1 l:1` under an action holding `s` | lane read visibility for verdict-lane work: a plain read of a parent-held node serves committed and re-derives at the landing. Not at the memo | D-26, F-6 | V1 | |
| 57 | +| R8 | leaf `latest(m0)` under `Loading` keeps the fallback up when `m0`'s first answer landed in the action's tick | `verdictValue`/`heldLatest`: a held first answer is a produced value (`b`, not `f0`) | D-22, S-45 | Vl4 | |
| 58 | +| R4 | `[latest(x), latest(y)]` over two holds tears when the first hold's lane reveals | `verdict.ts` `route`: the `!passLane` short-circuit skips `linkLanes`; a second hold's verdict lane links like a second optimistic lane does | A15 #3335, D-25 | D4 link | |
| 59 | +| R1 | `[x(), isPending(x)]` on a mainline flip is held; the other order shows `[0, true]` | `markVerdictReader`'s "already JOINED → no posture" arm: on a first probe after a plain read, restart the pass once with verdict posture. Scoped by D-25: not for a pass born in the hold's world or re-run by its write | D-25, A10 | V1, B1 | |
| 60 | + |
| 61 | +R7 and R8 are the generator's E9 differences and may already be filed among |
| 62 | +#4374–#4378; check before filing. R4 and R1 need issues with the minimized |
| 63 | +repro. |
| 64 | + |
| 65 | +In flight already: #4362, #4363, #4364, #4367 (#4380), #4372–#4378. Merged: |
| 66 | +#4355 (#4369), #4366 (#4381), #4379 (#4392). The #4365 fix in progress |
| 67 | +should be checked against the seam above before it opens. |
| 68 | + |
| 69 | +Each pin cites the rule by id in a comment and the scenario where one exists |
| 70 | +(`S-45` for R8). `rules-index --check` must stay green. |
| 71 | + |
| 72 | +## 3. Gate (P0b) |
| 73 | + |
| 74 | +#4371 is on `next`. Add: |
| 75 | + |
| 76 | +- Record/compare across two builds (`ASYNC_GEN_RECORD` / `ASYNC_GEN_COMPARE`): |
| 77 | + settle-point screens per case; zero new differences is the merge gate for |
| 78 | + every carve step. |
| 79 | +- Pairs with their ruled expectations: E4 (`[a, b]` vs `[b, a]`: both show |
| 80 | + `[committed, true]`, D-25), E5 (inline probe vs probe in a memo, D-25), |
| 81 | + E8 as render effects only (D-2; the memo variant's D-2 difference is the |
| 82 | + expected baseline, not a failure), E9 with `v:0 l:1` (R7) and reveal (R8) |
| 83 | + as the expected screens. |
| 84 | +- A CI job: seeds 3289, 91501, 7; 2,000 cases each; owned and unowned. |
| 85 | + |
| 86 | +Baseline must be zero on E4/E5/E9 after §2 lands. |
| 87 | + |
| 88 | +## 4. The carve, with four changes to the design |
| 89 | + |
| 90 | +The model (§2 of the design) and the table (§2.5) stand. These change: |
| 91 | + |
| 92 | +1. **Step 1 runs against the generator before step 2.** The shadow seat under |
| 93 | + `__TEST__` computes the table's predicted slot beside every decider and |
| 94 | + asserts agreement — on the suite _and_ on 50k generator cases per seed. |
| 95 | + Every mismatch is a table error or a bug on `next`. The table is correct |
| 96 | + before any behaviour moves. The two invariants — a leaf never raises its |
| 97 | + world; posture is never inherited — are pinned as `INV-*` here, not at |
| 98 | + step 9. |
| 99 | +2. **Step 4 is stated honestly.** `t._verdict` (today `newLane(t)`) stays as |
| 100 | + the record; `_ahead` is a rename and the design says so. What goes is |
| 101 | + seating verdict passes through `passLane` and the `_parent._verdict === l` |
| 102 | + arms (`core.ts:361`, `lanes.ts:645`, `:672`, `:934`, `verdict.ts:442`, |
| 103 | + `route`). Verdicts need no node set: `latest()` is read-level (D-27), so |
| 104 | + the posture is the whole mechanism. The isPending-page byte figure is |
| 105 | + re-derived from what actually becomes unreachable in `lanes.ts`, or |
| 106 | + dropped. R7 is the semantic reason verdict work must not use the lane |
| 107 | + read path: that path's visibility rule is the optimistic one. |
| 108 | +3. **Bytes are a tracked budget, not a per-step gate.** Steps 2–4 may be |
| 109 | + transiently positive. The hard check is after P0 and at step 9: the floor |
| 110 | + and compiled hello world do not grow. CodSpeed on every step as before. |
| 111 | +4. **Serial merges, isolated worktrees.** One PR lands at a time; each |
| 112 | + rebases; no two agents share a git store (the #4366/#4373 incident). |
| 113 | + |
| 114 | +The byte case is not the justification. The justification is the drift in |
| 115 | +§1 and the bug concentration the audit measured. Say that in the PR bodies. |
| 116 | + |
| 117 | +## 5. Exit for stable |
| 118 | + |
| 119 | +- The 50k differential is clean on all three seeds at step 9. |
| 120 | +- One week of generator CI on `next` with no new async issue. |
| 121 | + |
| 122 | +Not "step 9 merged." |
| 123 | + |
| 124 | +## 6. Out of scope, stated |
| 125 | + |
| 126 | +- The store twins (O3/O5; E3's nine signatures). After steps 5 and 8. |
| 127 | +- Hydration I27 (`CONFIG_IN_SNAPSHOT_SCOPE`). |
| 128 | +- #3905 itself. The table's world should remain a reference to a hold record, |
| 129 | + not a closed enum, so a fourth world could be a row rather than a |
| 130 | + restructuring — but nothing is built for it. |
| 131 | + |
| 132 | +## 7. Threads |
| 133 | + |
| 134 | +- **A — rules and pins.** §2's R5, R7, R8, R4, R1 in that order (R5 is live; |
| 135 | + R7/R8 are generator-visible; R4/R1 need issues first). Serial. |
| 136 | +- **B — in-flight fixes.** Lands #4362–#4378 serially with rebase; checks |
| 137 | + #4365's seam against §2. |
| 138 | +- **C — gate.** §3. |
| 139 | +- **Carve critical path** starts when A and B are merged and C baselines at |
| 140 | + zero on E4/E5/E9. Expect 4–5 thread-days before step 1 can start. |
0 commit comments