Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the required OIDC scopes (profile or webid) #29

Closed
jaxoncreed opened this issue Oct 22, 2020 · 8 comments · Fixed by #49
Closed

Clarify the required OIDC scopes (profile or webid) #29

jaxoncreed opened this issue Oct 22, 2020 · 8 comments · Fixed by #49
Assignees

Comments

@jaxoncreed
Copy link
Collaborator

The only mention oidc scope in the draft is in an example for the app WebID client registration: https://solid.github.io/authentication-panel/solid-oidc/#clientids-webid.

It lists openid profile offline_access. If my memory serves me correctly, this used to be openid profile offline_access where webid was a required scope to trigger the solid-oidc process.

Is this now profile? If so, there should be normative language stating so.

@acoburn
Copy link
Member

acoburn commented Oct 23, 2020

I don't believe there is any new scope defined in this spec.

@jaxoncreed
Copy link
Collaborator Author

I don't think profile makes sense for a scope, as that scope is usually to go an email and name, none of which is included in our token claim. Also, would it make sense to have a scope to get the webid claim? We used to have the webid scope.

@elf-pavlik
Copy link
Member

Looking at https://openid.net/specs/openid-connect-core-1_0.html#ScopeClaims
It seems reasonable to have webid scope if clients expects to get webid claim in the id token. Maybe even it would make sense solid scope to get solid access token.

@matthieubosquet
Copy link
Member

matthieubosquet commented Mar 8, 2021

Mentioned in discussions on solid/authentication-panel#141 via auth panel https://hackmd.io/tI_WdIvVSd2AaMBWt0D3_Q

I would +1 solid scope rather than webid since it seems consistent with the access token's audience claim.

Note: Adding scope will require a bit of work on the client side.

@acoburn
Copy link
Member

acoburn commented Mar 8, 2021

I could go either way between solid and webid (with a slight preference for solid). Requiring a scope would provide a clear mechanism for clients to signal that they want a solid access token.

Overall, +1 on using a scope for this.

@matthieubosquet
Copy link
Member

Can/should we transfer https://github.com/solid/authentication-panel/issues/86 & https://github.com/solid/authentication-panel/issues/146 to https://github.com/solid/solid-oidc?

I think the solid scope matched with a solid claim does make sense.

I couldn't pinpoint where the requirement is clearly expressed in the spec with a "MUST", but it seems to me that missing it is problematic.

@acoburn
Copy link
Member

acoburn commented Jul 23, 2021

Yes we can start transferring these issues

@acoburn acoburn transferred this issue from solid/authentication-panel Aug 11, 2021
@acoburn
Copy link
Member

acoburn commented Oct 4, 2021

This was discussed during the Sept 27, 2021 meeting, and it was resolved to require the webid scope for interactions where the webid claim is provided in access/ID tokens.

A related PR is forthcoming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants