Skip to content

Add missing null-check to findHostInstanceFastPath#6884

Merged
piaskowyk merged 1 commit intomainfrom
@piaskowyk/findNodeHandler-nullcheck
Jan 10, 2025
Merged

Add missing null-check to findHostInstanceFastPath#6884
piaskowyk merged 1 commit intomainfrom
@piaskowyk/findNodeHandler-nullcheck

Conversation

@piaskowyk
Copy link
Copy Markdown
Member

@piaskowyk piaskowyk commented Jan 10, 2025

Summary

This PR adds a missing null check for certain components that do not contain the _componentRef field. This can happen for example when you uses useAnimatedRef with FlashList.

Test plan

Use FlashList as a animated component

@piaskowyk piaskowyk marked this pull request as ready for review January 10, 2025 12:15
@piaskowyk piaskowyk requested a review from tomekzaw January 10, 2025 12:15
@piaskowyk piaskowyk added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 6c55c86 Jan 10, 2025
@piaskowyk piaskowyk deleted the @piaskowyk/findNodeHandler-nullcheck branch January 10, 2025 13:27
tomekzaw pushed a commit that referenced this pull request Jan 10, 2025
## Summary

This PR adds a missing null check for certain components that do not
contain the `_componentRef` field. This can happen for example when you
uses `useAnimatedRef` with FlashList.

## Test plan

Use FlashList as a animated component
This was referenced Jan 10, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
## Summary

This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

## Test plan

---------

Co-authored-by: Krzysztof Piaskowy <[email protected]>
tomekzaw pushed a commit that referenced this pull request Jan 13, 2025
## Summary

This PR adds a missing null check for certain components that do not
contain the `_componentRef` field. This can happen for example when you
uses `useAnimatedRef` with FlashList.

## Test plan

Use FlashList as a animated component
tjzel pushed a commit that referenced this pull request Feb 17, 2025
## Summary

This PR adds a missing null check for certain components that do not
contain the `_componentRef` field. This can happen for example when you
uses `useAnimatedRef` with FlashList.

## Test plan

Use FlashList as a animated component
tjzel pushed a commit that referenced this pull request Feb 17, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

---------

Co-authored-by: Krzysztof Piaskowy <[email protected]>
tjzel pushed a commit that referenced this pull request Feb 17, 2025
## Summary

This PR adds a missing null check for certain components that do not
contain the `_componentRef` field. This can happen for example when you
uses `useAnimatedRef` with FlashList.

## Test plan

Use FlashList as a animated component
tjzel pushed a commit that referenced this pull request Feb 17, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

---------

Co-authored-by: Krzysztof Piaskowy <[email protected]>
patrycjakalinska pushed a commit that referenced this pull request Mar 12, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

---------

Co-authored-by: Krzysztof Piaskowy <[email protected]>
patrycjakalinska pushed a commit that referenced this pull request Mar 13, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

---------

Co-authored-by: Krzysztof Piaskowy <[email protected]>
r0h0gg6 pushed a commit to r0h0gg6/react-native-reanimated that referenced this pull request Jul 28, 2025
…n#6884)

## Summary

This PR adds a missing null check for certain components that do not
contain the `_componentRef` field. This can happen for example when you
uses `useAnimatedRef` with FlashList.

## Test plan

Use FlashList as a animated component
r0h0gg6 pushed a commit to r0h0gg6/react-native-reanimated that referenced this pull request Jul 28, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* software-mansion#6875
* software-mansion#6876
* software-mansion#6883
* software-mansion#6884

---------

Co-authored-by: Krzysztof Piaskowy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants