Skip to content

Remove CoreFeatures.h include#6875

Merged
tomekzaw merged 1 commit intomainfrom
@tomekzaw/remove-include-core-features
Jan 9, 2025
Merged

Remove CoreFeatures.h include#6875
tomekzaw merged 1 commit intomainfrom
@tomekzaw/remove-include-core-features

Conversation

@tomekzaw
Copy link
Copy Markdown
Member

@tomekzaw tomekzaw commented Jan 8, 2025

Summary

This PR removes #include <react/utils/CoreFeatures.h> in ReanimatedModuleProxy.cpp which breaks build on RN 0.77.

See also facebook/react-native#45626

Test plan

@tomekzaw tomekzaw requested a review from piaskowyk January 8, 2025 15:18
@piaskowyk piaskowyk added the Check compatibility Trigger a time-consuming compatibility check action label Jan 8, 2025
Copy link
Copy Markdown
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's wait until the CI checks for backward compatibility. Once that's confirmed, we can merge

@tomekzaw tomekzaw added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit a1a327c Jan 9, 2025
@tomekzaw tomekzaw deleted the @tomekzaw/remove-include-core-features branch January 9, 2025 05:51
tomekzaw added a commit that referenced this pull request Jan 9, 2025
This PR removes `#include <react/utils/CoreFeatures.h>` in
ReanimatedModuleProxy.cpp which breaks build on RN 0.77.

See also facebook/react-native#45626
This was referenced Jan 10, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
## Summary

This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

## Test plan

---------

Co-authored-by: Krzysztof Piaskowy <[email protected]>
tomekzaw added a commit that referenced this pull request Jan 13, 2025
This PR removes `#include <react/utils/CoreFeatures.h>` in
ReanimatedModuleProxy.cpp which breaks build on RN 0.77.

See also facebook/react-native#45626
tjzel pushed a commit that referenced this pull request Feb 17, 2025
## Summary

This PR removes `#include <react/utils/CoreFeatures.h>` in
ReanimatedModuleProxy.cpp which breaks build on RN 0.77.

See also facebook/react-native#45626

## Test plan
tjzel pushed a commit that referenced this pull request Feb 17, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

---------

Co-authored-by: Krzysztof Piaskowy <[email protected]>
tjzel pushed a commit that referenced this pull request Feb 17, 2025
## Summary

This PR removes `#include <react/utils/CoreFeatures.h>` in
ReanimatedModuleProxy.cpp which breaks build on RN 0.77.

See also facebook/react-native#45626

## Test plan
tjzel pushed a commit that referenced this pull request Feb 17, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

---------

Co-authored-by: Krzysztof Piaskowy <[email protected]>
patrycjakalinska pushed a commit that referenced this pull request Mar 12, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

---------

Co-authored-by: Krzysztof Piaskowy <[email protected]>
patrycjakalinska pushed a commit that referenced this pull request Mar 13, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* #6875
* #6876
* #6883
* #6884

---------

Co-authored-by: Krzysztof Piaskowy <[email protected]>
r0h0gg6 pushed a commit to r0h0gg6/react-native-reanimated that referenced this pull request Jul 28, 2025
## Summary

This PR removes `#include <react/utils/CoreFeatures.h>` in
ReanimatedModuleProxy.cpp which breaks build on RN 0.77.

See also facebook/react-native#45626

## Test plan
r0h0gg6 pushed a commit to r0h0gg6/react-native-reanimated that referenced this pull request Jul 28, 2025
This PR bumps `react-native` in paper-example and fabric-example from
`0.76.5` to `0.77.0-rc.6` (golden RC) accordingly to
https://react-native-community.github.io/upgrade-helper/?from=0.76.5&to=0.77.0-rc.6.

Apart from this, changes have been made in macos-example, tvos-example
and web-example to align versions of common native dependencies so they
are hoisted by yarn.

I had to patch `@shopify/flash-list`:
* Shopify/flash-list#1466 – fixes Android
build
* Shopify/flash-list#1041 – fixes `scrollTo`
example

Changes required by Reanimated to support RN 0.77 have been moved to
separate PRs for the sake of atomicity and transparency:
* software-mansion#6875
* software-mansion#6876
* software-mansion#6883
* software-mansion#6884

---------

Co-authored-by: Krzysztof Piaskowy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Check compatibility Trigger a time-consuming compatibility check action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants