Skip to content

Comments

[project_class_refactor::03] Replace old code in init. Refactor init.#364

Merged
kasperski95 merged 42 commits intomasterfrom
refactor/integrate-protostar-toml
Jun 21, 2022
Merged

[project_class_refactor::03] Replace old code in init. Refactor init.#364
kasperski95 merged 42 commits intomasterfrom
refactor/integrate-protostar-toml

Conversation

@kasperski95
Copy link
Contributor

@kasperski95 kasperski95 commented Jun 14, 2022 •
edited
Loading

  • connected protostar_toml to init
  • refactored init
  • mark as ready to review once ::02 is merged

kasperski95 and others added 23 commits June 6, 2022 13:51
@kasperski95
add protostar_toml
4c448cc
@kasperski95
add types
7a99b74
@kasperski95
move sections to separate files
05c141f
@kasperski95
handle saving
9eae574
@kasperski95
refactor
4892b24
@kasperski95
refactor
b4a14d8
@kasperski95
refactor
f0146f5
@kasperski95
format
05865b0
@kasperski95
format
2690f89
@kasperski95
Merge branch 'master' of https://github.com/software-mansion/protostar …
2ab0793 
…into refactor/project-to-protostar-toml
@kasperski95
add test
808633b
@kasperski95
rename type
5559060
@kasperski95
Merge branch 'refactor/project-to-protostar-toml' of https://github.c…
946dc17 
…om/software-mansion/protostar into refactor/add-tests-to-protostar-toml
@kasperski95
add protostar_config_section_test
94afa27
@kasperski95
add protostar_contracts_section_test
256d436
@kasperski95
add protostar_project_section_test
d8d7c52
@kasperski95
add protostar_toml_exceptions_test
c306ad2
@kasperski95
add protostar_toml_reader_test
3d0a4e6
@kasperski95
add protostar_toml_writer_test
da23754
@kasperski95
add integration test
c494867
@kasperski95
format
cf40ef2
@kasperski95
use in init
bbbcf26
@kasperski95
refactor init command
2aa5fee
@kasperski95 kasperski95 changed the title Refactor/integrate protostar toml [project_class_refactor::03] Replace old code Jun 14, 2022
@kasperski95 kasperski95 changed the title [project_class_refactor::03] Replace old code [project_class_refactor::03] Replace old code in init. Refactor init. Jun 14, 2022
@kasperski95 kasperski95 self-assigned this Jun 14, 2022
@kasperski95 kasperski95 marked this pull request as ready for review June 14, 2022 12:13
@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #364 (aeb53ff) into master (b9b74f6) will increase coverage by 0.36%.
The diff coverage is 63.50%.

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   83.99%   84.36%   +0.36%     
==========================================
  Files         108      113       +5     
  Lines        3868     3920      +52     
==========================================
+ Hits         3249     3307      +58     
+ Misses        619      613       -6
Impacted Files Coverage Δ
protostar/protostar_cli_test.py 95.34% <ø> (ø)
protostar/commands/init/init_command.py 71.79% <47.61%> (+27.79%) ⬆️
...mmands/init/project_creator/new_project_creator.py 52.77% <52.77%> (ø)
protostar/utils/requester.py 53.84% <53.84%> (ø)
...ds/init/project_creator/adapted_project_creator.py 62.50% <62.50%> (ø)
.../commands/init/project_creator/_project_creator.py 81.81% <81.81%> (ø)
protostar/commands/__init__.py 100.00% <100.00%> (ø)
protostar/commands/init/__init__.py 100.00% <100.00%> (ø)
...rotostar/commands/init/project_creator/__init__.py 100.00% <100.00%> (ø)
protostar/protostar_cli.py 98.24% <100.00%> (+0.16%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9b74f6...aeb53ff. Read the comment docs.

@kasperski95 kasperski95 marked this pull request as draft June 17, 2022 08:57
Base automatically changed from refactor/add-tests-to-protostar-toml to master June 17, 2022 14:34
@kasperski95 kasperski95 marked this pull request as ready for review June 17, 2022 14:35
MaksymilianDemitraszek
MaksymilianDemitraszek approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@MaksymilianDemitraszek MaksymilianDemitraszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generaly very good, I like the way you implemented it. Some minor comments please addres them before merging

@kasperski95 kasperski95 merged commit 050683f into master Jun 21, 2022
@kasperski95 kasperski95 deleted the refactor/integrate-protostar-toml branch June 21, 2022 15:37
MaksymilianDemitraszek pushed a commit that referenced this pull request Jun 19, 2023
@dependabot
Bump pytest-mock from 3.10.0 to 3.11.1 (#2095)
68e8edc 
Bumps [pytest-mock](https://github.com/pytest-dev/pytest-mock) from
3.10.0 to 3.11.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/pytest-dev/pytest-mock/releases">pytest-mock's
releases</a>.</em></p>
<blockquote>
<h2>v3.11.1</h2>
<ul>
<li>
<p>Fixed introspection for failed <code>assert_has_calls</code> (<a
href="https://redirect.github.com/pytest-dev/pytest-mock/issues/365">#365</a>).</p>
</li>
<li>
<p>Updated type annotations for <code>mocker.patch</code> and
<code>mocker.spy</code> (<a
href="https://redirect.github.com/pytest-dev/pytest-mock/issues/364">#364</a>).</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pytest-dev/pytest-mock/blob/main/CHANGELOG.rst">pytest-mock's
changelog</a>.</em></p>
<blockquote>
<h2>3.11.1 (2023-06-15)</h2>
<p>(This release source code is identical to <code>3.11.0</code> except
a small internal fix to deployment/CI)</p>
<ul>
<li>
<p>Fixed introspection for failed <code>assert_has_calls</code>
(<code>[#365](https://github.com/pytest-dev/pytest-mock/issues/365)</code>_).</p>
</li>
<li>
<p>Updated type annotations for <code>mocker.patch</code> and
<code>mocker.spy</code>
(<code>[#364](https://github.com/pytest-dev/pytest-mock/issues/364)</code>_).</p>
</li>
</ul>
<p>.. _<a
href="https://redirect.github.com/pytest-dev/pytest-mock/issues/365">#365</a>:
<a
href="https://redirect.github.com/pytest-dev/pytest-mock/pull/365">pytest-dev/pytest-mock#365</a>
.. _<a
href="https://redirect.github.com/pytest-dev/pytest-mock/issues/364">#364</a>:
<a
href="https://redirect.github.com/pytest-dev/pytest-mock/pull/364">pytest-dev/pytest-mock#364</a></p>
<h2>3.11.0 (2023-06-15)</h2>
<ul>
<li>
<p>Fixed introspection for failed <code>assert_has_calls</code>
(<code>[#365](https://github.com/pytest-dev/pytest-mock/issues/365)</code>_).</p>
</li>
<li>
<p>Updated type annotations for <code>mocker.patch</code> and
<code>mocker.spy</code>
(<code>[#364](https://github.com/pytest-dev/pytest-mock/issues/364)</code>_).</p>
</li>
</ul>
<p>.. _<a
href="https://redirect.github.com/pytest-dev/pytest-mock/issues/365">#365</a>:
<a
href="https://redirect.github.com/pytest-dev/pytest-mock/pull/365">pytest-dev/pytest-mock#365</a>
.. _<a
href="https://redirect.github.com/pytest-dev/pytest-mock/issues/364">#364</a>:
<a
href="https://redirect.github.com/pytest-dev/pytest-mock/pull/364">pytest-dev/pytest-mock#364</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pytest-dev/pytest-mock/commit/d3e73f2e93f7b93eba0a36e17e43bafd969da4fe"><code>d3e73f2</code></a>
Explicitly specify the tag name during GitHub Release</li>
<li><a
href="https://github.com/pytest-dev/pytest-mock/commit/5668efe23e01673af9905febeefd9a9791b023f4"><code>5668efe</code></a>
Update CHANGELOG for 3.11.0</li>
<li><a
href="https://github.com/pytest-dev/pytest-mock/commit/c9a4d13ab4e808ef02250898a79c07b2acf76f61"><code>c9a4d13</code></a>
Improve CI</li>
<li><a
href="https://github.com/pytest-dev/pytest-mock/commit/5818160717a16b7f8867d950ed60b9dc3349ec8d"><code>5818160</code></a>
Add assert_has_calls_wrapper (<a
href="https://redirect.github.com/pytest-dev/pytest-mock/issues/365">#365</a>)</li>
<li><a
href="https://github.com/pytest-dev/pytest-mock/commit/355b5aae1a1a9b3f2c17b2a6bbfde9980967bceb"><code>355b5aa</code></a>
Fix return type annotation for patch and spy (<a
href="https://redirect.github.com/pytest-dev/pytest-mock/issues/364">#364</a>)</li>
<li><a
href="https://github.com/pytest-dev/pytest-mock/commit/8ba681201488bec69f27f6e9e2a56988a01f0d1b"><code>8ba6812</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/pytest-dev/pytest-mock/issues/362">#362</a>)</li>
<li><a
href="https://github.com/pytest-dev/pytest-mock/commit/786eaaf416fed8204a8aebb29cbf71527228a9f6"><code>786eaaf</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/pytest-dev/pytest-mock/issues/360">#360</a>)</li>
<li><a
href="https://github.com/pytest-dev/pytest-mock/commit/1cb146af21ffd0b5be24703419cf4a192c4ec0ab"><code>1cb146a</code></a>
Push tag manually</li>
<li><a
href="https://github.com/pytest-dev/pytest-mock/commit/9608e9659b1f062bb09915f3ef1c538ca7cb5c5f"><code>9608e96</code></a>
Update permissions for deploy workflow</li>
<li><a
href="https://github.com/pytest-dev/pytest-mock/commit/c778ee73bd516d465dca3512d099682ba32108fa"><code>c778ee7</code></a>
Fix deployment workflow (<a
href="https://redirect.github.com/pytest-dev/pytest-mock/issues/358">#358</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/pytest-dev/pytest-mock/compare/v3.10.0...v3.11.1">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pytest-mock&package-manager=pip&previous-version=3.10.0&new-version=3.11.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MaksymilianDemitraszek MaksymilianDemitraszek MaksymilianDemitraszek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kasperski95 kasperski95

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kasperski95 @MaksymilianDemitraszek