Repository navigation
fix: center code-block header controls above the divider - #960
Merged
hryhoriiK97 merged 4 commits intoOct 10, 2026
Merged
hryhoriiK97 merged 4 commits into
hryhoriiK97 merged 4 commits into
Conversation
juliusmarminge
marked this pull request as ready for review
October 8, 2026 18:49
The Robolectric test asserts two values derived from the same formula, and the screenshot baseline duplicates what the existing code block goldens already capture. Co-Authored-By: Claude Fable 5.1 <[email protected]>
The language label and copy icon moved, so the four existing code block screenshots on iOS and Android are regenerated and pass at the strict threshold. Co-Authored-By: Claude Fable 5.1 <[email protected]>
hryhoriiK97
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
The language label and copy icon sit too low relative to the code-block header divider. Center both in the actual header band on iOS and Android, retaining the existing block height, code pane and highlighting.
Fixes #953.
Testing
Same controlled fixture, theme, viewport and scroll position. Pixel-preserving crops from actual upstream base and head builds:
Before:
After:
Local native proof uses an isolated upstream example checkout on an iPhone 17 Pro simulator running iOS 27. Xcode used two jobs, disabled signing/index/debug symbols, and task-owned XCFrameworks retained the arm64 simulator slice to fit the host. These are host resource settings, not workflow or production changes. No Android device, VoiceOver traversal, or full Maestro-suite pass is claimed.
Base: b80be973. Current head: d42c0bfd. CI remains incomplete, with current-head iOS jobs queued.
PR Checklist
Model: GPT-6.1. Harness: Codex in T3 Code.