Repository navigation
fix(android): include the slot's generated shadow node by its codegen path - #1087
Merged
hryhoriiK97 merged 1 commit intoOct 26, 2026
Merged
hryhoriiK97 merged 1 commit into
hryhoriiK97 merged 1 commit into
Conversation
… path ComponentDescriptors.h included "ShadowNodes.h" by its bare name, so in an app whose include path lists another codegen library first (async-storage, react-native-menu and others ship a ShadowNodes.h too) autolinking.cpp found that library's header and failed: unknown type name 'EnrichedMarkdownBlockSlotShadowNode'. The other headers already use the react/renderer/components/EnrichedMarkdownTextSpec/ path.
This was referenced Oct 24, 2026
hryhoriiK97
approved these changes
Oct 26, 2026
juliusmarminge
added a commit
to pingdotgg/enriched-markdown
that referenced
this pull request
Nov 6, 2026
Upstream merged our software-mansion#1086, software-mansion#1087, software-mansion#1088 and software-mansion#1089; the fork's copies of software-mansion#1088 and software-mansion#1089 were reverted first because upstream edited them before merging. Conflicts were the md4c flag lists, where upstream added strikethrough (software-mansion#1090) next to our preserveWindowsPaths, and the parser TurboModule's flag struct now has ten fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
The custom
ComponentDescriptors.hfrom #1027 includes the generated header by its bare name,#include "ShadowNodes.h". The app'sautolinking.cppcompiles with every library's codegen directory on the include path. Several libraries generate their ownShadowNodes.h, so whichever comes first wins. In T3 Code that is@react-native-async-storage/async-storage's, and the build fails:The library's other headers already include generated files by their codegen path. This includes
ShadowNodes.hthe same way:<react/renderer/components/EnrichedMarkdownTextSpec/ShadowNodes.h>.Testing
mainwith the error above and builds with this change.clang-formatis clean.PR Checklist
Model: Claude Opus 5.5. Harness: Claude Code in T3 Code.