Improve Start-Sleep cmdlet to accept fractional seconds (#8477)#6
Open
TommiTallgren wants to merge 3 commits intomasterfrom
Open
Improve Start-Sleep cmdlet to accept fractional seconds (#8477)#6TommiTallgren wants to merge 3 commits intomasterfrom
TommiTallgren wants to merge 3 commits intomasterfrom
Conversation
- "Seconds" parameter of Start-Sleep function is now interpreted as double. This removes the rounding error when the parameter with fractions is converted to milliseconds. - ValidateRangeAttribute parameters converted to double to remove error when Seconds parameter is now of double type.
|
Softagram identified no dependency changes nor impact in this change (head commit d0a8304) Check the full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
double. This removes the rounding error when the parameter with
fractions is converted to milliseconds.
when Seconds parameter is now of double type.
Fix PowerShell#8477
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests