Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

Conversation

@zjulbj
Copy link
Contributor

@zjulbj zjulbj commented Nov 6, 2023

需求

支持 #128 arklet and sofaark 日志配置支持 logging.file.path

修改点

  • ServerlessEnvironmentPostProcessor中新增一个“compatiblePropertySource”用于各种兼容性配置
  • ArkletApplicationListener提前初始化了ArkletLogger导致一些配置使用了系统默认配置,调整到CommonLoggingApplicationListener之后

Copy link
Collaborator

@yuanyuancin yuanyuancin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

Copy link
Collaborator

@lvjing2 lvjing2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6dfb885) 67.67% compared to head (ad0084a) 67.86%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #249      +/-   ##
============================================
+ Coverage     67.67%   67.86%   +0.18%     
+ Complexity      296      295       -1     
============================================
  Files            75       75              
  Lines          1680     1696      +16     
  Branches        108      110       +2     
============================================
+ Hits           1137     1151      +14     
- Misses          470      471       +1     
- Partials         73       74       +1     
Files Coverage Δ
...ss/arklet/core/common/log/ArkletLoggerFactory.java 40.00% <ø> (+6.66%) ⬆️
...ot/starter/listener/ArkletApplicationListener.java 75.00% <ø> (-6.82%) ⬇️
...mon/spring/ServerlessEnvironmentPostProcessor.java 82.53% <ø> (+2.53%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants