-
Notifications
You must be signed in to change notification settings - Fork 41
Compatible springboot3 #235
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #235 +/- ##
=========================================
Coverage 67.67% 67.67%
Complexity 296 296
=========================================
Files 75 75
Lines 1680 1680
Branches 108 108
=========================================
Hits 1137 1137
Misses 470 470
Partials 73 73 ☔ View full report in Codecov by Sentry. |
| @@ -0,0 +1,34 @@ | |||
| ## SOFAServerless 支持中间件列表与样例 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件当前已经调整路径到 samples/ 下了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
调整完毕
|
|
||
| ### 支持 Java EE/Jakarta EE | ||
| 随着 Oracle 将 Java EE 交给 Eclipse 开始 Java EE 就成为了历史,取而代之的是新的 Jakarta EE 系列。对于开发者而言,最大的改变便是从 jakarta EE 9 开始, EE 相关的类的命名空间从 javax.* 迁移到了 jakarta.*。 | ||
| 对于这一变更,开源社区的组件也均在不同进度的进行升级适配:例如 Tomcat 从 10.x 版本开始便迁移到了 jakarta 命名空间。而 SpringBoot 3.x 版本也不再支持 Java EE 8,而是基于 Jakarta EE 9 构建。 为了支持 Jakarta EE,sofa-ark 将从 2.2.4 开始发布后缀为 `-jakarta`的包。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里说明下 sofaArk 是同时发布 带和不带 '-jakarta' 的两个版本,说明使用的不同场景,并这段也需要补充到 sofaArk 官网里。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
被上sofa-serverless-base-starter 包含掉了, 就不需要说明了
| <dependency> | ||
| <groupId>com.alipay.sofa</groupId> | ||
| <artifactId>sofa-ark-support-starter</artifactId> | ||
| <version>2.2.4-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不需要调整 version 吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
调整完毕
| public void cleanUp() { | ||
| if (isBridgeHandlerAvailable()) { | ||
| removeJdkLoggingBridgeHandler(); | ||
| try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确保 jdk8 单测运行正常的情况下,补充下 jdk 17 的单测。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有额外修改, 直接try catch了
…mpatible-springboot3
| @@ -0,0 +1 @@ | |||
| com.alipay.sofa.serverless.log4j2.SOFAServerlessLog4j2SpringContextListener No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listener也是通过AutoConfiguration.imports文件声明的?
yuanyuancin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM
lvjing2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
compatible-springboot3 and add examples
Modification
Describe the idea and modifications you've done.
Result
Resolved or fixed #.
If there is no issue then describe the changes introduced by this PR.