Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

Conversation

@qixiaobo
Copy link
Contributor

override method to avoid no default method support in interface

Motivation

override method to avoid no default method support in interface

override method to avoid no default method support in interface In previous spring framework , BeanPostProcessor not use default method in interface. We should override this method to avoid cause AbstractMethodError in this case.

Modification

Just add override method

Result

Resolved or fixed #.

If there is no issue then describe the changes introduced by this PR.

…support in interface

override method to avoid no default method support in interface
In previous spring framework , BeanPostProcessor not use default method in interface.
We should override this method to avoid cause AbstractMethodError in this case.
@sofastack-cla
Copy link

sofastack-cla bot commented Oct 25, 2023

Hi @qixiaobo, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

Copy link
Collaborator

@lvjing2 lvjing2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvjing2 lvjing2 requested a review from yuanyuancin November 3, 2023 08:27
@lvjing2
Copy link
Collaborator

lvjing2 commented Nov 3, 2023

这两个报错,一个是 cla, 一个是需要本地先执行下格式化 mvn clean package 命令

…support in interface

override method to avoid no default method support in interface
In previous spring framework , BeanPostProcessor not use default method in interface.
We should override this method to avoid cause AbstractMethodError in this case.
…support in interface

override method to avoid no default method support in interface
In previous spring framework , BeanPostProcessor not use default method in interface.
We should override this method to avoid cause AbstractMethodError in this case.

Fix format problem
# Conflicts:
#	sofa-serverless-runtime/sofa-serverless-common/src/main/java/com/alipay/sofa/serverless/common/service/ArkAutowiredBeanPostProcessor.java
@sofastack-cla sofastack-cla bot added cla:yes and removed cla:no labels Nov 4, 2023
@codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (10e9763) 82.80% compared to head (bf9a639) 67.63%.
Report is 36 commits behind head on master.

❗ Current head bf9a639 differs from pull request most recent head 1c1bb05. Consider uploading reports for the commit 1c1bb05 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #210       +/-   ##
=============================================
- Coverage     82.80%   67.63%   -15.17%     
- Complexity      131      296      +165     
=============================================
  Files            37       75       +38     
  Lines           878     1681      +803     
  Branches         66      108       +42     
=============================================
+ Hits            727     1137      +410     
- Misses          110      471      +361     
- Partials         41       73       +32     
Files Coverage Δ
.../common/service/ArkAutowiredBeanPostProcessor.java 80.00% <0.00%> (-1.49%) ⬇️

... and 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TomorJM TomorJM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glmapper
Copy link

glmapper commented Nov 7, 2023

LGTM

@sofastack-cla sofastack-cla bot added size/XXL and removed size/XS labels Nov 10, 2023
@sofastack-cla sofastack-cla bot added size/XS and removed size/XXL labels Nov 10, 2023
@lvjing2 lvjing2 merged commit 8fa52a7 into sofastack:master Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants