Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

Spring cross-context calls with interface #175

Merged
lvjing2 merged 17 commits into from
Oct 20, 2023
Merged

Spring cross-context calls with interface #175

lvjing2 merged 17 commits into from
Oct 20, 2023

Conversation

@yuanyuancin
Copy link
Collaborator

@yuanyuancin yuanyuancin commented Oct 17, 2023

  1. add samples for spring cross-context calls
  2. add docs for spring cross-context calls
  3. optimize spring cross-context calls with interface

@yuanyuancin yuanyuancin requested a review from lvjing2 October 17, 2023 11:38
@yuanyuancin yuanyuancin linked an issue Oct 17, 2023 that may be closed by this pull request
模块间通信优化 #149
Closed
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (43a4e94) 25.24% compared to head (6e39578) 25.12%.
Report is 412 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #175      +/-   ##
============================================
- Coverage     25.24%   25.12%   -0.13%     
  Complexity      102      102              
============================================
  Files            72       72              
  Lines          1632     1640       +8     
  Branches        102      103       +1     
============================================
  Hits            412      412              
- Misses         1189     1197       +8     
  Partials         31       31
Files Coverage Δ
...ofa/serverless/common/api/SpringServiceFinder.java 92.30% <100.00%> (ø)
...y/sofa/serverless/common/exception/ErrorCodes.java 0.00% <ø> (ø)
...erverless/common/service/SpringServiceInvoker.java 41.17% <ø> (ø)
...re/command/builtin/handler/QueryAllBizHandler.java 11.76% <0.00%> (-1.57%) ⬇️
.../common/service/ArkAutowiredBeanPostProcessor.java 0.00% <0.00%> (ø)
...serverless/common/service/ServiceProxyFactory.java 66.19% <57.14%> (-2.38%) ⬇️
...ore/command/builtin/handler/InstallBizHandler.java 5.88% <0.00%> (-1.02%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lvjing2
lvjing2 reviewed Oct 17, 2023
View reviewed changes
docs/content/zh-cn/docs/tutorials/module-development/module-and-base-communication.md
# Spring 环境

## 基座调用模块

Copy link
Collaborator

@lvjing2 lvjing2 Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充几句说明

...less-common/src/main/java/com/alipay/sofa/serverless/common/service/ServiceProxyFactory.java
if (targetClass.isInterface()) {
factory.addInterface(targetClass);
if (serviceType.isInterface()) {
factory.addInterface(serviceType);
Copy link
Collaborator

@lvjing2 lvjing2 Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测需要覆盖

lvjing2
lvjing2 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@lvjing2 lvjing2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvjing2 lvjing2 merged commit 235bf17 into master Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@lvjing2 lvjing2 lvjing2 approved these changes

@TomorJM TomorJM TomorJM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla:yes size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

模块间通信优化

5 participants

@yuanyuancin @lvjing2 @TomorJM @yuanyuan2021