Skip to content

Conversation

@hacke2
Copy link
Contributor

@hacke2 hacke2 commented Sep 26, 2023

Motivation:

Enable sofa-rpc to support Web IDE for browsing code.

Modification:

Added ant codespaces badge to support Web IDE.

Result:

image

@sofastack-cla
Copy link

sofastack-cla bot commented Sep 26, 2023

Hi @hacke2, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@sofastack-cla sofastack-cla bot added cla:no Need sign CLA First-time contributor First-time contributor size/XS labels Sep 26, 2023
@nobodyiam
Copy link
Member

@hacke2 please sign the cla first, thanks!

@zhenjunMa zhenjunMa closed this Sep 26, 2023
@zhenjunMa zhenjunMa reopened this Sep 26, 2023
@sofastack-cla sofastack-cla bot added the cla:yes CLA is ok label Sep 26, 2023
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (666261d) 72.03% compared to head (c06a10f) 72.01%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1370      +/-   ##
============================================
- Coverage     72.03%   72.01%   -0.03%     
  Complexity      784      784              
============================================
  Files           416      416              
  Lines         17661    17661              
  Branches       2752     2752              
============================================
- Hits          12722    12718       -4     
- Misses         3537     3538       +1     
- Partials       1402     1405       +3     
Files Coverage Δ
...fa/rpc/bootstrap/dubbo/DubboConsumerBootstrap.java 84.21% <100.00%> (ø)
...lipay/sofa/rpc/bootstrap/dubbo/DubboConvertor.java 90.00% <100.00%> (ø)
...fa/rpc/bootstrap/dubbo/DubboProviderBootstrap.java 54.05% <ø> (ø)
...lipay/sofa/rpc/bootstrap/dubbo/DubboSingleton.java 88.88% <100.00%> (ø)
.../main/java/com/alipay/sofa/rpc/common/Version.java 100.00% <ø> (ø)
.../alipay/sofa/rpc/log/factory/RpcLoggerFactory.java 77.77% <ø> (ø)
...alipay/sofa/rpc/registry/local/DomainRegistry.java 94.26% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit d9c2fac into sofastack:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:no Need sign CLA cla:yes CLA is ok First-time contributor First-time contributor size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants