Skip to content

[Simulation.Core] Remove dead code - #6298

Closed
alxbilger wants to merge 3 commits into
sofa-framework:masterfrom
alxbilger:deadcode
Closed

[Simulation.Core] Remove dead code#6298
alxbilger wants to merge 3 commits into
sofa-framework:masterfrom
alxbilger:deadcode

Conversation

@alxbilger

@alxbilger alxbilger commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Some methods in MechanicalOperations can be removed. As a result, the visitors which were used only in those methods can also be removed.

Due to the removal of the visitor MechanicalMultiVectorPeqBaseVectorVisitor, we can consider to deprecate BaseMechanicalState::addFromBaseVectorSameSize.

To do:

  • deprecation

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Sep 8, 2026
@alxbilger

Copy link
Copy Markdown
Contributor Author

Replaced by #6305

@alxbilger alxbilger closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status wip Development in the pull-request is still in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant