You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Memory management (need more work, I could not test it)
See context switching
Mutex profiling (not tested yet)
I tried not to be invasive, but it will require a change on the way we define timers such as in master...alxbilger:sofa:scoped_timer (the demo runs with this branch).
Very cool and useful indeed! It really look like the one in unity!
I see the Tracy lib is under BSD license, is it a problem to add it in the core of SOFA ? @hugtalbot
otherwise we should move the profiler into another repo?
Very cool and useful indeed! It really look like the one in unity! I see the Tracy lib is under BSD license, is it a problem to add it in the core of SOFA ? @hugtalbot otherwise we should move the profiler into another repo?
@alxbilger did it in a way we dont even ship it with SOFA as it will downloaded from their repo at the cmake step.
Moreover, this is for developers so the binary distribution would not contain the compiled lib anyway.
In any case, BSD licence is very lax anyway so it should be OK.
The screenshots on the repo look mad 🤩 (even asm views of statement 😶🌫️)
I am especially interested of the multi-threading part, as the profiler of MSVC (and the valgrind/callgrind on linux) does not really handle it well.
Do you need to compile with debug info?
It is tracing so obviously there will be overhead, but can you say how much is the performance hit (if any) ? (msvc's is almost as fast but requires RelWithDebugInfo and callgrind is slow like hell)
EDIT: tried myself, works in Release mode as well 😎👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I integrated the Tracy profiler (https://github.com/wolfpld/tracy). It adds a ton of new feature to our internal profiler. In particular, I like:
I tried not to be invasive, but it will require a change on the way we define timers such as in master...alxbilger:sofa:scoped_timer (the demo runs with this branch).
TODO: a dedicated MessageHandler
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if