fix: prefilter segfault #872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bugfix for a segmentation fault in
mmseqs prefilter, which occured in the following circumstances:seqLenof sequences larger than32768are overridden to1to lower their priority in diagonal score calculationmin(seqs[i].seqLen - minDistToDiagonal, minSeqLen);returns an underflowed value for lowseqLen, which holds for the above case (UngappedAlignment L:279)=> this invalid
seqLengthvalue causesunrolledDiagonalScoring(...)to access memory out of bounds, causing a seg faultChanges
seqLengthhaving invalid(underflowed) valuesseqLenlarger than32768are overridden to0instead of1, in order to completely skip the processing insideunrolledDiagonalScoring(...)Other Details