@drjauss This PR seems to remove a bunch of content from the package-lock.json file. Can you redo? Otherwise I can do the url-parse upgrade this evening (PDT).

@drjauss This PR seems to remove a bunch of content from the package-lock.json file. Can you redo? Otherwise I can do the url-parse upgrade this evening (PDT).

Hello @brycekahle, thank you for your reply,
these are changes happening after running npm install [email protected].
I removed them in order for you to check if those lockfile changes were needed.

Thank you! 👍

Hello @brycekahle, this PR has been updated by @drjauss. Could you please check again? Thank you 🙂

[email protected] was released, see https://github.com/unshiftio/url-parse/tags.

Do we need to upgrade the url-parse dependency to 1.5.3?

[email protected] was released, see https://github.com/unshiftio/url-parse/tags.

Do we need to upgrade the url-parse dependency to 1.5.3?

Hi @leslieli , I think the purpose of this PR/issue is to solve the security vulnerability exposed on the 1.5.1, but we could also do so.

Thanks.

Hi @brycekahle , could you please review again? Thanks.

Hi @brycekahle, is there something missing in order for this PR to be merged?

Hi folks. I just committed a fix and published 1.5.2.