Skip to content

Conversation

@iyegoroff
Copy link
Contributor

@iyegoroff iyegoroff commented Jun 21, 2017

It looks like because of some strict type checks on Java side code:
this.xhr.withCredentials = 'true';
leads to error:
TypeError: expected dynamic type 'boolean', but had type 'string'.

When I changed 'true' to true the error has gone.

@brycekahle
Copy link
Contributor

Thanks!

@brycekahle brycekahle merged commit a1028ed into sockjs:master Jun 21, 2017
@Dofff
Copy link

Dofff commented Jun 22, 2017

@iyegoroff i'that fixed.... but same issue.. what`s the problem?

@asgvard
Copy link

asgvard commented Aug 11, 2017

Probably because it's fixed in source folder, but not in dist minified version.
@brycekahle could we expect new build and npm version soon? It's quite important fix for RN users. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants