allows [Object: null prototype] in binary packet#114
Merged
darrachequesne merged 1 commit intosocketio:masterfrom Feb 17, 2022
Merged
allows [Object: null prototype] in binary packet#114darrachequesne merged 1 commit intosocketio:masterfrom
darrachequesne merged 1 commit intosocketio:masterfrom
Conversation
…with a null prototype
Member
|
@Gabba90 thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I get the following error when trying to encode a binary packet with a null prototype object:
I think the solutions is to simply use the safer version of the call to
hasOwnProperty, just like here.Let me know what you think of it.