Closed
Conversation
This was referenced Feb 22, 2021
5 tasks
Member
|
Merged as 6abfa1f and included in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
If a client app is trying to reconnect, it leaves a
refd timer on the event loop which will prevent the program from exiting.New behaviour
With this change, if a user passes
autoUnref: truethe reconnect timer getsunrefd each time it is created so that if it would have been the only thing preventing the event loop from exiting, the program exits.Other information (e.g. related issues)
This coordinates well with (but is in a sense independent of) this PR on engine.io-client:
socketio/engine.io-client#652
Please note the
refandunrefAPI mentioned there which is available on other Node internals such as timers, sockets, and servers.