Fix type of SocketOptions.agent property #708
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
The current type definition of the
agentproperty ofSocketOptionsmakes it difficult to pass in a custom http agent because it only accepts astringor aboolean:In order to pass in a custom agent you need to do something like:
New behaviour
The type of the
agentproperty now allows includeshttp.Agentandhttps.Agent.I think the correct type should actually be
http.Agent | https.Agent | false, but I kept the originalstring | booleanfor backwards compatibility.Other information (e.g. related issues)