[fix] Replace deprecated Buffer usage#565
Merged
darrachequesne merged 1 commit intosocketio:masterfrom Nov 19, 2018
oliversalzburg:fix/deprecated-buffer
Merged
[fix] Replace deprecated Buffer usage#565darrachequesne merged 1 commit intosocketio:masterfrom oliversalzburg:fix/deprecated-buffer
darrachequesne merged 1 commit intosocketio:masterfrom
oliversalzburg:fix/deprecated-buffer
Conversation
Contributor
Author
|
Seems to me like the test failures were introduced by |
Contributor
Author
|
I believe socketio/engine.io-client@99bcc62 introduced these failures, because |
Member
|
Thanks for the pull request, could you please review my comment? I'll try to fix the issue with json-polling. |
The `Buffer` constructor has been deprecated in favor of safer alternatives. See https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/
Contributor
Author
|
@darrachequesne Should be good now :) |
darrachequesne
pushed a commit
that referenced
this pull request
Nov 19, 2018
The `Buffer` constructor has been deprecated in favor of safer alternatives. See https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Bufferconstructor has been deprecated in favor of safer alternatives.See https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/
The kind of change this PR does introduce
Current behaviour
The
Bufferconstructor is used.New behaviour
Buffer.fromis used instead.Other information (e.g. related issues)
The
READMEhas also been adjusted to not use the constructor in the example.