refactor: return HTTP 400 upon invalid request overlap

darrachequesne · darrachequesne · commit 911d0e35757e · 2023-05-01T07:42:43.000+02:00
In both cases, the error comes from the client as it should not send multiple concurrent requests, so a HTTP 4xx code is mandated. Related: #650
diff --git a/lib/transports/polling.ts b/lib/transports/polling.ts
@@ -75,8 +75,7 @@ export class Polling extends Transport {
       debug("request overlap");
       // assert: this.res, '.req and .res should be (un)set together'
       this.onError("overlap from client");
-      // TODO for the next major release: use an HTTP 400 status code (https://github.com/socketio/engine.io/issues/650)
-      res.writeHead(500);
+      res.writeHead(400);
       res.end();
       return;
     }
@@ -117,8 +116,7 @@ export class Polling extends Transport {
     if (this.dataReq) {
       // assert: this.dataRes, '.dataReq and .dataRes should be (un)set together'
       this.onError("data request overlap from client");
-      // TODO for the next major release: use an HTTP 400 status code (https://github.com/socketio/engine.io/issues/650)
-      res.writeHead(500);
+      res.writeHead(400);
       res.end();
       return;
     }
