Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify coverage and set thresholds #508

Merged
merged 15 commits into from
Aug 16, 2021
Merged

Unify coverage and set thresholds #508

merged 15 commits into from
Aug 16, 2021

Conversation

silverbucket
Copy link
Member

@silverbucket silverbucket commented Aug 3, 2021 •
edited
Loading

Uses c8 everywhere (removes some use of nyc), and ensures each package that has tests sets thresholds so we don't drop below in the future.

@silverbucket silverbucket added type:feature kredits-2 Medium contribution labels Aug 3, 2021
@silverbucket silverbucket requested review from raucao and galfert August 3, 2021 23:04
@silverbucket silverbucket self-assigned this Aug 3, 2021
@silverbucket silverbucket changed the title Use c8 everywhere and set coverage thresholds Unify coverage and set thresholds Aug 3, 2021
@silverbucket
Copy link
Member Author

@galfert @raucao this PR is ready for review, unifies on c8 for coverage reporting and sets reasonable thresholds for each package.

@silverbucket
Copy link
Member Author

ping @galfert or @raucao for review?

@silverbucket silverbucket mentioned this pull request Aug 16, 2021
Merged
galfert
galfert approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@galfert galfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

@silverbucket silverbucket merged commit 7d0fa15 into master Aug 16, 2021
@silverbucket silverbucket deleted the set-coverage-thresholds branch August 16, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galfert galfert galfert approved these changes

@raucao raucao Awaiting requested review from raucao

Assignees

@silverbucket silverbucket

Labels
kredits-2 Medium contribution state:ready type:feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silverbucket @galfert