Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to incoming XMPP messages #362

Merged
merged 2 commits into from
Apr 18, 2021

Conversation

raucao
Copy link
Contributor

@raucao raucao commented Apr 17, 2021

Add timestamp for messages that haven't been received live (e.g. from offline storage, or room archives). (This already results in correct timestamps for messages in Hyperchannel.)

https://xmpp.org/extensions/xep-0203.html
https://www.w3.org/TR/activitystreams-vocabulary/#dfn-published

Use unique stanza ID instead of random integers.

https://xmpp.org/extensions/xep-0359.html

The commit also does a bit of drive-by cleanup of the code turning incoming chat messages into AS objects. It also ditches messages without content/body, of which I found some that aren't important and that we can support later if we choose.

@raucao raucao added kredits-2 Medium contribution platform-xmpp labels Apr 17, 2021
@raucao raucao requested a review from silverbucket April 17, 2021 18:01
Copy link
Member

@silverbucket silverbucket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@silverbucket silverbucket added this to the XMPP Platform milestone Apr 18, 2021
@silverbucket silverbucket merged commit cc2026e into master Apr 18, 2021
@raucao raucao deleted the feature/xmpp_message_metadata branch April 18, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kredits-2 Medium contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants