fix: add alpine platform to standalone binary release assets#608
Merged
yuliabaron merged 1 commit intomasterfrom Jun 27, 2019
Merged
fix: add alpine platform to standalone binary release assets#608yuliabaron merged 1 commit intomasterfrom
yuliabaron merged 1 commit intomasterfrom
Conversation
f034742 to
e3dd22d
Compare
e3dd22d to
fd44fc0
Compare
yuliabaron
approved these changes
Jun 27, 2019
|
🎉 This PR is included in version 1.185.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Finding a way to build a good standalone alpine image using
pkg.Naive
pkg . -t alpinegenerates a broken binary (segfault on a plain alpine image). Generating one inside an alpine container works.