Skip to content

fix: add alpine platform to standalone binary release assets#608

Merged
yuliabaron merged 1 commit intomasterfrom
fix/alpine-binary
Jun 27, 2019
Merged

fix: add alpine platform to standalone binary release assets#608
yuliabaron merged 1 commit intomasterfrom
fix/alpine-binary

Conversation

@adrukh
Copy link
Copy Markdown
Contributor

@adrukh adrukh commented Jun 27, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Finding a way to build a good standalone alpine image using pkg.

Naive pkg . -t alpine generates a broken binary (segfault on a plain alpine image). Generating one inside an alpine container works.

@adrukh adrukh force-pushed the fix/alpine-binary branch 2 times, most recently from f034742 to e3dd22d Compare June 27, 2019 08:04
@adrukh adrukh force-pushed the fix/alpine-binary branch from e3dd22d to fd44fc0 Compare June 27, 2019 08:18
@adrukh adrukh changed the title wip: testing out alpine image building fix: add alpine platform to standalone binary release assets Jun 27, 2019
@adrukh adrukh self-assigned this Jun 27, 2019
@adrukh adrukh requested a review from yuliabaron June 27, 2019 09:03
@yuliabaron yuliabaron merged commit 5dcbf33 into master Jun 27, 2019
@yuliabaron yuliabaron deleted the fix/alpine-binary branch June 27, 2019 09:44
@snyksec
Copy link
Copy Markdown

snyksec commented Jun 27, 2019

🎉 This PR is included in version 1.185.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants