Conversation
maxjeffos
reviewed
Apr 16, 2021
maxjeffos
reviewed
Apr 16, 2021
|
|
||
| If you want to send data to Snyk, and be alerted when new vulnerabilities are discovered, you can run Snyk monitor like so: | ||
|
|
||
| If you want to send data to Snyk, and be alerted when new vulnerabilities are discovered, you can run [Snyk monitor](https://support.snyk.io/hc/en-us/articles/360000920818-What-is-the-difference-between-snyk-test-protect-and-monitor-) like so: |
There was a problem hiding this comment.
Suggested change
| If you want to send data to Snyk, and be alerted when new vulnerabilities are discovered, you can run [Snyk monitor](https://support.snyk.io/hc/en-us/articles/360000920818-What-is-the-difference-between-snyk-test-protect-and-monitor-) like so: | |
| If you want to send data to Snyk, and be alerted when new vulnerabilities are discovered, you can run [`snyk monitor`](https://support.snyk.io/hc/en-us/articles/360000920818-What-is-the-difference-between-snyk-test-protect-and-monitor-) like so: |
Contributor
Author
There was a problem hiding this comment.
I don't like doing that, because GH makes the link almost invisible in code blocks
maxjeffos
approved these changes
Apr 17, 2021
maxjeffos
left a comment
maxjeffos
left a comment
There was a problem hiding this comment.
Made a bunch of comments / suggestions. Feel free to disregard if you don't like them.
And add Snyk footer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can preview this branch here: https://github.com/snyk/actions/tree/feat/oss-sarif
This PR documents the SARIF upload step for all Actions, except for the Docker and IAC which already implements it.
Because of a requirements for
--filefor the Docker scanning, we choose not to implement theinputoption forsarif, but rather are nudging users to use the standard CLI flags and the official GitHub's Action for SARIF upload.We've considered embedding the upload into the Snyk Action, but GitHub Actions don't support composite actions actions/runner#646
Closes #47