Merged
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
dotkas
force-pushed
the
dotkas/add-generated-action-tests
branch
10 times, most recently
from
f082dad to
ccfd489
Compare
dotkas
changed the title
dotkas
force-pushed
the
dotkas/add-generated-action-tests
branch
3 times, most recently
from
1fc50d1 to
332aa64
Compare
dotkas
commented
Aug 14, 2025
Comment on lines
+50
to
+53
| - uses: actions/checkout@v4 | ||
| # This looks odd, but the `matrix.variant` as input in `uses` is not supported by Github. | ||
| # Therefore, we must add every step as a conditional instead, if we don't want to generate an | ||
| # individual workflow for each variant. |
Contributor
Author
There was a problem hiding this comment.
As the comment states, I was unable to find a way to get GH actions to accept matrix.variant as an input variable to uses if the runner was docker. Hence this oddity.
j-luong
approved these changes
Aug 15, 2025
# Conflicts: # README.md # _templates/BASE.md.erb
dotkas
force-pushed
the
dotkas/add-generated-action-tests
branch
from
332aa64 to
18ea261
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure we're not adding actions for which Snyk is not installed or where an image does not exist.