Skip to content

chore: add better logging to setup action script#153

Merged
j-luong merged 5 commits intomasterfrom
chore/CLI-471_refactorSetup
Aug 23, 2024
Merged

chore: add better logging to setup action script#153
j-luong merged 5 commits intomasterfrom
chore/CLI-471_refactorSetup

Conversation

@j-luong
Copy link
Copy Markdown
Contributor

@j-luong j-luong commented Aug 16, 2024

This PR should

  • add timestamps to log output
  • output expected and actual shasums when validation fails
  • download binary and shasum from the same URL before retrying with backup URL
  • fails download on any 400+ status code

@j-luong j-luong force-pushed the chore/CLI-471_refactorSetup branch from c04c022 to 6a854b4 Compare August 19, 2024 09:51
@j-luong j-luong marked this pull request as ready for review August 19, 2024 09:56
@j-luong j-luong requested a review from a team as a code owner August 19, 2024 09:56
Copy link
Copy Markdown
Contributor

@PeterSchafer PeterSchafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@PeterSchafer PeterSchafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@j-luong j-luong merged commit 9213221 into master Aug 23, 2024
@j-luong j-luong deleted the chore/CLI-471_refactorSetup branch August 23, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants