feat: change downloadurl and add fallback on setup action#148
feat: change downloadurl and add fallback on setup action#148
Conversation
aa4a42a to
7643863
Compare
Co-authored-by: PeterSchafer <[email protected]>
Co-authored-by: PeterSchafer <[email protected]>
…)" This reverts commit ae94425.
|
@PeterSchafer @j-luong Have seen some checksum failed errors recently and it's not altogether clear why, which suggests that curl got an response from the remote server that indicated there was an error and saved it to the output file and returned zero as the exit code. Should this script use The errors also highlighted than if there is an issue with the binary downloaded from downloads.snyk.io/cli due to the checksum, there is no fallback to static.snyk.io/cli. Only individual downloads will fallback, so could end up with a binary from https://downloads.snyk.io/cli and checksum from https://static.snyk.io/cli and not clear if that is a problem. |
|
#150 Is a revert of this merged feature, for the record. |
|
In my opinion, if the binary is downloaded from one of the sources, than the checksum file should also be downloaded from the exact same source. I'm thinking of a scenario where both are out of sync, for some reason, and they the are downloaded from different sources. |
This PR changes the default download url to https://downloads.snyk.io/, adds a backup URL that uses https://static.sn/ yk.io, for downloading the Snyk CLI
Changes
Testing
Tested the script to ensure: