feat: add ability for customer to specify custom docker image#122
Merged
nathan-roys merged 1 commit intomasterfrom Jun 13, 2023
Merged
feat: add ability for customer to specify custom docker image#122nathan-roys merged 1 commit intomasterfrom
nathan-roys merged 1 commit intomasterfrom
Conversation
j-luong
approved these changes
Jun 13, 2023
Contributor
j-luong
left a comment
j-luong
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does:
Adds a
docker_imageparameter to applicable actions which will allow customers to use their own custom images if required.To use your own docker image you'd have to run the login flow to your image registry and then specify the full url of the docker image in the
docker_imagevariable:my-artifactory-instance.jfrog.io/my-docker-repo/my-image:tag