Skip to content

SNOW-698916 support Python 3.11#1349

Merged
sfc-gh-mkeller merged 11 commits intosnowflakedb:mainfrom
noamcohen97:feature/3.11
Jan 25, 2023
Merged

SNOW-698916 support Python 3.11#1349
sfc-gh-mkeller merged 11 commits intosnowflakedb:mainfrom
noamcohen97:feature/3.11

Conversation

@noamcohen97
Copy link
Copy Markdown
Contributor

@noamcohen97 noamcohen97 commented Nov 25, 2022 •
edited
Loading

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 25, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@noamcohen97
Copy link
Copy Markdown
Contributor Author

noamcohen97 commented Nov 25, 2022

I have read the CLA Document and I hereby sign the CLA

This was referenced Nov 25, 2022
Closed
Merged
Closed
@noamcohen97 noamcohen97 mentioned this pull request Nov 25, 2022
Closed
7 tasks
3dbrows
3dbrows reviewed Nov 25, 2022
View reviewed changes
3dbrows
3dbrows reviewed Nov 25, 2022
View reviewed changes
3dbrows
3dbrows reviewed Nov 25, 2022
View reviewed changes
3dbrows
3dbrows reviewed Nov 25, 2022
View reviewed changes
3dbrows
3dbrows reviewed Nov 25, 2022
View reviewed changes
3dbrows
3dbrows reviewed Nov 25, 2022
View reviewed changes
3dbrows
3dbrows suggested changes Nov 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@3dbrows 3dbrows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some commit suggestions for the libarrow_dataset library which appears to be necessary with Arrow 10.

@noamcohen97 @3dbrows
Apply suggestions from code review
445fc31 
Co-authored-by: Duncan MacQuarrie <[email protected]>
@potiuk
Copy link
Copy Markdown
Contributor

potiuk commented Nov 25, 2022

🤞

@idanmiara
Copy link
Copy Markdown

idanmiara commented Nov 27, 2022

Thanks @noamcohen97
I can confirm that it builds and installs locally on Python 3.11 on macos.

@noamcohen97
Copy link
Copy Markdown
Contributor Author

noamcohen97 commented Dec 1, 2022

@sfc-gh-mkeller Can you please have a look?

sfc-gh-mkeller
sfc-gh-mkeller reviewed Dec 1, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the team:

  • We'll need to update manylinux2014_x86_64 docker images on our internal mirror ✅
  • We need to setup Python 3.11 on Mac and Windows Jenkins workers and seed the new 3.11 jobs ✅
  • Generate new Jenkins test jobs ✅
  • Probably update gosu versions in the Dockerfiles ✅

Otherwise I think the PR itself looks good!
@noamcohen97 would you mind bumping the gosu version to the newest one in your PR too?

@sfc-gh-mkeller sfc-gh-mkeller self-assigned this Dec 1, 2022
@noamcohen97
Copy link
Copy Markdown
Contributor Author

noamcohen97 commented Dec 1, 2022

Thanks for reviewing @sfc-gh-mkeller!

would you mind bumping the gosu version to the newest one in your PR too

Sure! Will do.

Also, would you mind approving the workflows so build and tests will run?

@noamcohen97
Copy link
Copy Markdown
Contributor Author

noamcohen97 commented Dec 1, 2022

BTW, would you like me to add an entry to the release notes?

@joshuataylor joshuataylor mentioned this pull request Dec 2, 2022
Closed
6 tasks
@thomasaarholt thomasaarholt mentioned this pull request Dec 3, 2022
Closed
@noamcohen97
Copy link
Copy Markdown
Contributor Author

noamcohen97 commented Dec 10, 2022

@sfc-gh-mkeller any updates on this?

@patrickmckenna patrickmckenna mentioned this pull request Dec 13, 2022
Closed
@dataders
Copy link
Copy Markdown
Contributor

dataders commented Dec 14, 2022 •
edited
Loading

hi @sfc-gh-aling and @sfc-gh-mkeller sorry to "at" you here, but we're blocked on dbt-labs/dbt-snowflake#336 which is needed for the next minor version of dbt-core and dbt-snowflake. 👀 @colin-rogers-dbt

@sfc-gh-mkeller
Copy link
Copy Markdown
Collaborator

sfc-gh-mkeller commented Dec 14, 2022

BTW, would you like me to add an entry to the release notes?

Yes, absolutely!

@sfc-gh-mkeller any updates on this?

We're currently blocked on our Windows and Mac Jenkins workers having Python 3.11 installed. We have completed the rest of the steps necessary to merge this. That being said our target to release Python 3.11 support is in the January release.

@3dbrows
Copy link
Copy Markdown
Contributor

3dbrows commented Dec 14, 2022

@sfc-gh-mkeller Any chance of merging #1336 in the meantime, which upgrades PyArrow, but not Python? This might also be of some interest to @dataders .

The advantage would be that it would raise the version ceiling on PyArrow in any projects which use the Snowflake connector.

@noamcohen97
Copy link
Copy Markdown
Contributor Author

noamcohen97 commented Jan 6, 2023

our target to release Python 3.11 support is in the January release.

@sfc-gh-mkeller Sounds great! looking forward for it

@sfc-gh-mkeller
Copy link
Copy Markdown
Collaborator

sfc-gh-mkeller commented Jan 10, 2023

pyarrow==10.0.1 support was merged through #1347
This PR will need to be rebased

@noamcohen97
Copy link
Copy Markdown
Contributor Author

noamcohen97 commented Jan 11, 2023

BTW, would you like me to add an entry to the release notes?

Yes, absolutely!

Done!

@Yarden-zamir
Copy link
Copy Markdown

Yarden-zamir commented Jan 17, 2023

Hi, whatsup with this? I really would love to have 3.11

@yogevyuval
Copy link
Copy Markdown

yogevyuval commented Jan 17, 2023

@sfc-gh-mkeller Hi! Any news regarding this? We would love to test python 3.11

@Yarden-zamir
Copy link
Copy Markdown

Yarden-zamir commented Jan 18, 2023 •
edited
Loading

Note for people who need this but are not patient, you can use the branch of this pr in your requirements / pip install like so

git+https://github.com/noamcohen97/snowflake-connector-python.git@feature/3.11

This was referenced Jan 24, 2023
Closed
Merged
@sfc-gh-mkeller sfc-gh-mkeller changed the title SNOW-698916 : Bump PyArrow version to support Python 3.11 SNOW-698916 support Python 3.11 Jan 24, 2023
sfc-gh-mkeller
sfc-gh-mkeller approved these changes Jan 25, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-mkeller sfc-gh-mkeller merged commit c08ba70 into snowflakedb:main Jan 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
@noamcohen97 noamcohen97 deleted the feature/3.11 branch January 25, 2023 05:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

+2 more reviewers

@xhochy xhochy xhochy left review comments

@3dbrows 3dbrows 3dbrows requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sfc-gh-mkeller sfc-gh-mkeller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SNOW-698916: Pyarrow 8 is not compatible with Python 3.11

9 participants

@noamcohen97 @potiuk @idanmiara @dataders @sfc-gh-mkeller @3dbrows @Yarden-zamir @yogevyuval @xhochy