Update pyarrow requirement from <8.1.0,>=8.0.0 to >=10.0.1,<10.1.0#1336
Update pyarrow requirement from <8.1.0,>=8.0.0 to >=10.0.1,<10.1.0#13363dbrows wants to merge 15 commits intosnowflakedb:mainfrom
Conversation
Updates the requirements on [pyarrow](https://github.com/apache/arrow) to permit the latest version. - [Release notes](https://github.com/apache/arrow/releases) - [Commits](apache/arrow@go/v8.0.0...go/v10.0.0) --- updated-dependencies: - dependency-name: pyarrow dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Running |
|
created this branch that builds: #1349 |
|
Fantastic, thank you @noamcohen97 , I see you upgraded to C++ 17 which is important as Arrow has updated to this recently. I will try including your C++ changes in this branch as well. The maintainers can then choose if they want to close this PR and accept only yours, or accept this one without the Python 3.11 change as well. I am happy either way. Thank you again. |
|
I think if a new version is released, it might as well have new wheels built for 3.11 |
would really appreciate a co-authored-by on this :) |
|
btw @noamcohen97 I found I had to add And yep, might as well do 3.11 at the same time.
Yes, absolutely, how do I do this, edit a commit message I guess? |
Nice!
Yes, Thank you 😊 |
6ef3365 to
e86cbfd
Compare
Co-authored-by: Noam Cohen (noamcohen97) <[email protected]>
Co-authored-by: Noam Cohen (noamcohen97) <[email protected]>
e86cbfd to
b8d8b8c
Compare
|
@noamcohen97 I think the attribution is fixed now :) |
|
Should it be >= 10.0.1 (for the Python 3.11 support)? edit: Installing from local whl file on M1 Mac works perfectly :) 🎉 My poetry file looks like this: [tool.poetry.dependencies]
python = "^3.11"
snowflake-connector-python = { file = "/Users/josh/dev/snowflake-connector-python/dist/snowflake_connector_python-2.8.3-cp311-cp311-macosx_12_0_arm64.whl" } |
|
Very well spotted @joshuataylor , thank you, I've bumped this to 10.0.1. |
|
Perhaps this is a useless comment, but I checked out |
|
Anything blocking merging this PR? |
|
@cpcloud Looks like it's just the description release notes that require updating - should these be updated in this PR, or is that done when the release is cut? If they should be updated now - under what (future) version number? |
|
Merged through #1347 |
This is intended to replace the dependabot PR #1304 by also updating pyproject.toml, and fixing us to one major version.
I am not too sure how to test this against the C++ ArrowIterator. Will the CI test suite be enough?
cc @sfc-gh-sfan .