Skip to content

Update pyarrow requirement from <8.1.0,>=8.0.0 to >=8.0.0,<10.1.0#1304

Closed
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/pip/pyarrow-gte-8.0.0-and-lt-10.1.0
Closed

Update pyarrow requirement from <8.1.0,>=8.0.0 to >=8.0.0,<10.1.0#1304
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/pip/pyarrow-gte-8.0.0-and-lt-10.1.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Oct 28, 2022

Updates the requirements on pyarrow to permit the latest version.

Commits
  • 89f9a09 MINOR: [Release] Update versions for 10.0.0
  • cb64545 MINOR: [Release] Update .deb/.rpm changelogs for 10.0.0
  • 6776681 MINOR: [Release] Update CHANGELOG.md for 10.0.0
  • c81588e ARROW-17954: [R] Update news for 10.0 (#14337)
  • a12fce7 ARROW-17317: [Release][Docs] Normalize previous document version directory (#...
  • 7d4bc9b ARROW-18103: [Packaging][deb][RPM] Fix upload artifacts patterns (#14462)
  • 6278176 ARROW-17891: [Docs][Python] Update and sync Win section of the developers/pyt...
  • 8f03259 ARROW-17353: [Release][R] Validate binaries version (#14396)
  • a735316 ARROW-18083: [C++] Bump vendored zlib version (#14446)
  • eea4a54 ARROW-17524: [C++] Correction for fields included when reading an ORC table (...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 28, 2022
@dependabot dependabot bot requested review from a team, sfc-gh-aalam and sfc-gh-jdu and removed request for a team October 28, 2022 15:03
@sfc-gh-sfan
Copy link
Copy Markdown
Contributor

This likely won't work. For pyarrow my understanding is that we need to pin to one major version because our c-extension is built against it.

Updates the requirements on [pyarrow](https://github.com/apache/arrow) to permit the latest version.
- [Release notes](https://github.com/apache/arrow/releases)
- [Commits](apache/arrow@go/v8.0.0...go/v10.0.0)

---
updated-dependencies:
- dependency-name: pyarrow
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/pyarrow-gte-8.0.0-and-lt-10.1.0 branch from 0fab821 to e4c8eb5 Compare November 1, 2022 19:46
@3dbrows
Copy link
Copy Markdown
Contributor

3dbrows commented Nov 9, 2022

I think this PR also needs to update pyproject.toml line 9.

I'm strongly in favour of updating to pyarrow v10.

@sfc-gh-sfan :

we need to pin to one major version because our c-extension is built against it.

By "c-extension" are we talking about libsnowflakeclient?

@sfc-gh-sfan
Copy link
Copy Markdown
Contributor

@3dbrows I mean the arrow iterator that was written in C. I'm not sure if there is any negative impact if we don't pin it to only one major version: https://github.com/snowflakedb/snowflake-connector-python/tree/main/src/snowflake/connector/cpp/ArrowIterator

@3dbrows
Copy link
Copy Markdown
Contributor

3dbrows commented Nov 21, 2022

I have expanded upon this in #1336

@sfc-gh-mkeller
Copy link
Copy Markdown
Collaborator

Superseded by #1336

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Nov 23, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/pyarrow-gte-8.0.0-and-lt-10.1.0 branch November 23, 2022 19:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants