SNOW-630797 Support table_type in pandas_tools #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sfan
requested review from
sfc-gh-kwagner and
sfc-gh-mkeller
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1216 +/- ##
==========================================
- Coverage 81.76% 81.71% -0.06%
==========================================
Files 59 59
Lines 8495 8502 +7
Branches 1375 1377 +2
==========================================
+ Hits 6946 6947 +1
- Misses 1242 1247 +5
- Partials 307 308 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Contributor
Author
|
Will add a test for invalid table type. Thanks CodeCov report :) |
4 tasks
sfc-gh-jdu
approved these changes
Aug 3, 2022
sfc-gh-mkeller
requested changes
Aug 4, 2022
Description table_type could support transient table as well, which is more flexible comparing to create_temp_table Testing Added integ test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
table_type could support transient table as well, which is more
flexible comparing to create_temp_table
Testing
Added integ test
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.