Repository navigation
SNOW-1800528 don't log anything if logLevel is set to OFF - #958
Merged
sfc-gh-dszmolka merged 2 commits intoNov 13, 2024
Merged
Conversation
…ging configuration
sfc-gh-dprzybysz
approved these changes
Nov 13, 2024
sfc-gh-fpawlowski
approved these changes
Nov 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #958 +/- ##
==========================================
+ Coverage 88.87% 88.90% +0.02%
==========================================
Files 69 69
Lines 6685 6685
==========================================
+ Hits 5941 5943 +2
+ Misses 744 742 -2 ☔ View full report in Codecov by Sentry. |
sfc-gh-pmotacki
approved these changes
Nov 13, 2024
sfc-gh-dszmolka
deleted the
SNOW-1800528-dont-log-anything-if-loglevel-off
branch
November 13, 2024 10:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #957 is was reported that even with
snowflake.configure({ logLevel: OFF });which is expected to disable logging; a single logline is still logged
at default
INFOlevel before setting loglevel to-1and actually disabling logging.Moving this logline to after the logger has been configured with local loglevel allows for preserve the same information for the ones who need it for tracking purposes, and stop logging it for the ones who wish the driver to not emit logs.
Checklist
npm run lint:check -- CHANGED_FILESand fix problems in changed code)npm run test:unitandnpm run test:integration)