Skip to content

Conversation

@lidavidm
Copy link

@lidavidm lidavidm commented Mar 12, 2025

Description

We noticed in the ADBC Snowflake driver that there was some stray logging output that appeared to come from gosnowflake. I think these should be changed to Debug level as they're not useful to the user and may confuse them instead. Also, changing the logger level doesn't help with the "Credentials cache path" message since that gets triggered by a global, before any application code can run.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@lidavidm lidavidm requested a review from a team as a code owner March 12, 2025 05:26
@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@sfc-gh-pfus
Copy link
Collaborator

Hi, there are a lot of changes in token caching going on: #1327
I checked that there are no info logs left. I'm going to close your PR, because it won't be applicable for the next release. Thank you for your valid suggestion, though!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants