-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop support for h-as-* classes, both incoming and outgoing #81
Conversation
mf2_types = mf2.get('type') or [] | ||
mf2_type = ('location' if 'h-geo' in mf2_types | ||
else 'person' if 'h-card' in mf2_types | ||
else mf2util.post_type_discovery(mf2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mf2util.post_type_discovery
currently returns 'person' for h-cards (or 'org' if the h-card has an org property that is the same as its name). I'd be more than happy to add 'h-geo' => location too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amending that per my other comment: happy to add "person", "location", etc. to the mf2util.post_type_discovery
algorithm, once we work out what that algorithm is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay thanks! updated.
woohoo, love it. and it looks good other than my question about the "h-card h-geo" thing; pretty sure we've talked about it in #microformats before ... need a card-type-discovery analogue to the post-type-discovery algorithm. |
drop support for h-as-* classes, both incoming and outgoing
@coveralls please, continue to keep us appraised of fluctuations of thousandths of a percent. |
oh snap! |
...they're deprecated in favor of https://indiewebcamp.com/post-type-discovery
hey @kylewm you're better at mf2 than me...mind giving this a once over? tia!
fixes snarfed/bridgy#635