Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for h-as-* classes, both incoming and outgoing #81

Merged
merged 2 commits into from
Mar 18, 2016
Merged

Conversation

snarfed
Copy link
Owner

@snarfed snarfed commented Mar 18, 2016

...they're deprecated in favor of https://indiewebcamp.com/post-type-discovery

hey @kylewm you're better at mf2 than me...mind giving this a once over? tia!

fixes snarfed/bridgy#635

mf2_types = mf2.get('type') or []
mf2_type = ('location' if 'h-geo' in mf2_types
else 'person' if 'h-card' in mf2_types
else mf2util.post_type_discovery(mf2))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mf2util.post_type_discovery currently returns 'person' for h-cards (or 'org' if the h-card has an org property that is the same as its name). I'd be more than happy to add 'h-geo' => location too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amending that per my other comment: happy to add "person", "location", etc. to the mf2util.post_type_discovery algorithm, once we work out what that algorithm is

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay thanks! updated.

@kylewm
Copy link
Contributor

kylewm commented Mar 18, 2016

woohoo, love it. and it looks good other than my question about the "h-card h-geo" thing; pretty sure we've talked about it in #microformats before ... need a card-type-discovery analogue to the post-type-discovery algorithm.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 94.911% when pulling 66c982c on h-as into c194aa3 on master.

snarfed added a commit that referenced this pull request Mar 18, 2016
drop support for h-as-* classes, both incoming and outgoing
@snarfed snarfed merged commit 65e9807 into master Mar 18, 2016
snarfed added a commit to snarfed/bridgy that referenced this pull request Mar 18, 2016
@kylewm
Copy link
Contributor

kylewm commented Mar 18, 2016

@coveralls please, continue to keep us appraised of fluctuations of thousandths of a percent.

@snarfed
Copy link
Owner Author

snarfed commented Mar 18, 2016

oh snap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple response types in the same post
3 participants