Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webmentions author data differs from bridgy #75

Closed
jk-na opened this issue Mar 11, 2021 · 3 comments
Closed

Webmentions author data differs from bridgy #75

jk-na opened this issue Mar 11, 2021 · 3 comments

Comments

@jk-na
Copy link

jk-na commented Mar 11, 2021 •
edited
Loading

Having just set up a mastodon account I can perform a few tests with bridgy fed and compare against bridgy I currently use for replies\shares etc. on posts syndicated to pleroma.

I've just replied to a post by my bridgyfed account @[email protected] from my mastodon account @[email protected] and the webmentions responses are mismatched. Also I received two webmentions for the one reply, on with a target of the note that I was replying to and one with a target of my website URL.

In the bridgy response webmention the author name and photo are correctly populated, however in the case of the bridgy fed webmention the name is the same as the URL and there is no photo.

I use the webmentions.io webhook for saving webmentions to json files.

Example of bridgy webmention:

{"type":"entry",
  "author":
       {"type":"card",
        "name":"Jkp🏴󠁧󠁢󠁳󠁣󠁴󠁿🇪🇺",
        "photo":"https://webmention.io/avatar/media.mastodon.scot/69c7e212eeb99cf382e80d671da393c92c41f643715a2e0e9a88b48de97c2dd2.jpg",
        "url":"https://mastodon.scot/@Jkp"},
    "url":"https://social.nipponalba.scot/notice/A4yZ46f3l5AHkTx4xk#favorited-by-9qEkWb1d76feMQOdRw",
    "published":null,
    "wm-received":"2021-03-09T20:35:55Z",
    "wm-id":1063173,
    "wm-source":"https://brid.gy/like/mastodon/@[email protected]/A4yZ46f3l5AHkTx4xk/9qEkWb1d76feMQOdRw",
    "wm-target":"https://jk.nipponalba.scot/note/60452443/",
    "like-of":"https://jk.nipponalba.scot/note/60452443/",
    "wm-property":"like-of",
    "wm-private":false
}

Example of bridgy fed webmention 1 - wm-target being the note I was replying to:

{"type":"entry",
 "author":
      {"type":"card",
       "name":"https://mastodon.scot/users/jk_na",
       "photo":"",
       "url":"https://mastodon.scot/users/jk_na"},
 "url":"https://mastodon.scot/@jk_na/105870901259631820","published":"2021-03-11T11:22:30",
 "wm-received":"2021-03-11T11:22:34Z",
 "wm-id":1066528,
 "wm-source":"https://fed.brid.gy/render?source=https%3A%2F%2Fmastodon.scot%2F%40jk_na%2F105870901259631820&target=https%3A%2F%2Fjk.nipponalba.scot%2Fnote%2F6049fa28%2F",
 "wm-target":"https://jk.nipponalba.scot/note/6049fa28/",
 "content":{
       "html":"<p><span class=\"h-card\"><a href=\"https://fed.brid.gy/r/https://jk.nipponalba.scot\" class=\"u-url\">@<span>jk.nipponalba.scot</span></a></span> test reply</p>\n<a class=\"u-mention\" href=\"https://jk.nipponalba.scot/\"></a>",
      "text":"@jk.nipponalba.scot test reply"},
 "in-reply-to":"https://jk.nipponalba.scot/note/6049fa28/",
 "wm-property":"in-reply-to",
 "wm-private":false
}

Example of bridgy fed webmention 2 - wm-target being to the website URI

{"type":"entry",
 "author":{
       "type":"card",
       "name":"https://mastodon.scot/users/jk_na",
       "photo":"","url":
       "https://mastodon.scot/users/jk_na"},
 "url":"https://mastodon.scot/@jk_na/105870901259631820",
 "published":"2021-03-11T11:22:30",
 "wm-received":"2021-03-11T11:22:34Z",
 "wm-id":1066527,
 "wm-source":"https://fed.brid.gy/render?source=https%3A%2F%2Fmastodon.scot%2F%40jk_na%2F105870901259631820&target=https%3A%2F%2Fjk.nipponalba.scot%2F",
 "wm-target":"https://jk.nipponalba.scot/",
 "content":{
       "html":"<p><span class=\"h-card\"><a href=\"https://fed.brid.gy/r/https://jk.nipponalba.scot\" class=\"u-url\">@<span>jk.nipponalba.scot</span></a></span> test reply</p>\n<a class=\"u-mention\" href=\"https://jk.nipponalba.scot/\"></a>",
       "text":"@jk.nipponalba.scot test reply"},
 "in-reply-to":"https://jk.nipponalba.scot/",
 "wm-property":"in-reply-to",
 "wm-private":false
}
@jk-na jk-na changed the title Webmentions account data differs from bridgy Webmentions author data differs from bridgy Mar 11, 2021
@snarfed
Copy link
Owner

snarfed commented Mar 11, 2021

Thanks for filing! I see the problem here, should be straightforward to fix.

snarfed added a commit to snarfed/granary that referenced this issue Mar 13, 2021
@snarfed
as2.to_as1(): for Create activities, include actor in object author
2838087 
for snarfed/bridgy-fed#75
@snarfed
Copy link
Owner

snarfed commented Mar 13, 2021

Fixed! You can see the new rendered HTML+mf2 in https://fed.brid.gy/render?source=https%3A%2F%2Fmastodon.scot%2F%40jk_na%2F105870901259631820&target=https%3A%2F%2Fjk.nipponalba.scot%2Fnote%2F6049fa28%2F , it now includes your name and profile picture correctly.

@snarfed snarfed closed this as completed Mar 13, 2021
@jk-na
Copy link
Author

jk-na commented Mar 14, 2021

confirmed, nice one, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snarfed @jk-na