Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple response types in the same post #635

Closed
barnabywalters opened this issue Mar 16, 2016 · 4 comments · Fixed by snarfed/granary#81
Closed

Support multiple response types in the same post #635

barnabywalters opened this issue Mar 16, 2016 · 4 comments · Fixed by snarfed/granary#81

Comments

@barnabywalters
Copy link

…if that’s not possible or awkward, document which will take priority if multiple are provided. For example, this post https://waterpigs.co.uk/notes/4gG89z/ is both a photo and an event RSVP, but when POSSEing to facebook using Publish it was treated just as a photo. From this I can assume that presence of a u-photo takes priority over presence of u-in-reply to p-rsvp — where do other response types fit into this?

@snarfed
Copy link
Owner

snarfed commented Mar 16, 2016

good point! at minimum, we should think through the order of precedence (and document it) more deliberately. rsvp should probably come before photo, for example. :P

do you know if there's any prior art or best practice documented anywhere for this yet? I'll go look on the wiki in a bit.

@snarfed
Copy link
Owner

snarfed commented Mar 16, 2016

we're probably more likely to just document the order of precedence than to try to get multi posting right. beyond problems like atomicity, we don't necessarily know the user's intent. i can imagine someone else with the same post might be a bit surprised if bridgy posted the rsvp and also the photo, separately. (maybe no more surprised than us choosing one, though. not sure.)

@barnabywalters if you're interested in a more powerful and configurable posse tool, definitely check it @kylewm's https://silo.pub/ ! more background: https://snarfed.org/2015-11-29_keep-bridgy-publish-dumb , https://kylewm.com/2015/11/silo-pub-as-a-generic-micropub-to-silo-adapter

@snarfed snarfed added the now label Mar 16, 2016
@barnabywalters
Copy link
Author

Sounds good to me, at the moment at least I’m very happy to continue using a “dumb” tool, provided I can understand exactly how it’s dumbness works :) So documenting the order of precedence would be great.

On 2016-03-16, at 16:20, Ryan Barrett [email protected] wrote:

we're probably more likely to just document the order of precedence than to try to get multi posting right. beyond problems like atomicity, we don't necessarily know the user's intent. i can imagine someone else with the same post might be a bit surprised if bridgy posted the rsvp and also the photo, separately. (maybe no more surprised than us choosing one, though. not sure.)

@barnabywalters https://github.com/barnabywalters if you're interested in a more powerful and configurable posse tool, definitely check it @kylewm https://github.com/kylewm's https://silo.pub/ https://silo.pub/ ! more background: https://snarfed.org/2015-11-29_keep-bridgy-publish-dumb https://snarfed.org/2015-11-29_keep-bridgy-publish-dumb , https://kylewm.com/2015/11/silo-pub-as-a-generic-micropub-to-silo-adapter https://kylewm.com/2015/11/silo-pub-as-a-generic-micropub-to-silo-adapter

@snarfed
Copy link
Owner

snarfed commented Mar 18, 2016

i dug into this a bit more, and we actually interpreted this specific post as a note with photo instead of an RSVP because it has class="h-as-note", which overrides post type discovery (http://indiewebcamp.com/post-type-discovery).

h-as-* classes are evidently deprecated, so the fix is probably just to remove support for them and fully follow post type discovery. easy to document too. :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants