start to migrate Chrome (but not Firefox) browser extension to manifest v3

snarfed · snarfed · commit d85f7ac313a8 · 2022-09-17T20:41:59.000-07:00
diff --git a/README.md b/README.md
@@ -168,6 +168,10 @@ Here's how to cut a new release of the browser extension and publish it [to addo
 
 Browser extension: Changelog
 ---
+0.6, unreleased
+
+* [Migrate from Manifest v2 to v3.](https://developer.chrome.com/docs/extensions/mv3/intro/mv3-migration/#man-sw) ([Ugh.](https://blog.mozilla.org/addons/2022/05/18/manifest-v3-in-firefox-recap-next-steps/))
+
 0.5, 2022-07-21
 
 * Update Instagram scraping.
diff --git a/browser-extension/background.js b/browser-extension/background.js
@@ -21,15 +21,17 @@ import {Facebook} from './facebook.js'
 
 const FREQUENCY_MIN = 30
 
-function schedulePoll() {
-  browser.alarms.onAlarm.addListener((alarm) => {
-    if (alarm.name == 'bridgy-facebook-poll') {
-      Facebook.poll()
-    } else if (alarm.name == 'bridgy-instagram-poll') {
-      Instagram.poll()
-    }
-  })
+// Must be top level in non-persistent background (aka event) pages
+// https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Background_scripts#move_event_listeners
+browser.alarms.onAlarm.addListener((alarm) => {
+  if (alarm.name == 'bridgy-facebook-poll') {
+    Facebook.poll()
+  } else if (alarm.name == 'bridgy-instagram-poll') {
+    Instagram.poll()
+  }
+})
 
+function schedulePoll() {
   for (const silo of [Instagram, Facebook]) {
     const name = silo.alarmName()
     browser.alarms.get(name).then(function(alarm) {
diff --git a/browser-extension/manifest.chrome.json b/browser-extension/manifest.chrome.json
@@ -0,0 +1,33 @@
+{
+	"name": "Bridgy",
+	"version": "0.6.0",
+	"description": "Bridgy connects your web site to social media. This extension adds Facebook and Instagram support.",
+	"homepage_url": "https://brid.gy/",
+    "manifest_version": 3,
+    "minimum_chrome_version": "74",
+    "permissions": [
+        "alarms",
+        "contextualIdentities",
+        "cookies",
+        "storage",
+        "webRequest",
+        "webRequestBlocking"
+    ],
+    "host_permissions": [
+        "*://*.brid.gy/*",
+        "*://*.instagram.com/*",
+        "*://*.facebook.com/*"
+    ],
+    "background": {
+        "service_worker": "background.js",
+        "type": "module"
+    },
+    "icons": {
+        "128": "bridgy_logo_128.jpg",
+        "1024": "bridgy_logo_square_1024.jpg"
+    },
+    "options_ui": {
+        "page": "options.html",
+        "browser_style": true
+    }
+}
diff --git a/browser-extension/manifest.firefox.json b/browser-extension/manifest.firefox.json
