handlers: bug fix for f823e41: pass fetch_likes, etc when prefetching posts

snarfed · snarfed · commit 7bd3a6d32905 · 2016-05-05T09:08:25.000-07:00
i haven't come up with a good (or even mediocre) test for this yet :/
diff --git a/handlers.py b/handlers.py
@@ -105,18 +105,19 @@ def get_title(self, obj):
     """
     return obj.get('title') or obj.get('content') or 'Bridgy Response'
 
-  def get_post(self, id):
+  def get_post(self, id, **kwargs):
     """Fetch a post.
 
     Args:
       id: string, site-specific post id
       is_event: bool
+      kwargs: passed through to get_activities
 
     Returns: ActivityStreams object dict
     """
     try:
       posts = self.source.get_activities(
-          activity_id=id, user_id=self.source.key.id())
+          activity_id=id, user_id=self.source.key.id(), **kwargs)
       if posts:
         return posts[0]
       logging.warning('Source post %s not found', id)
@@ -242,7 +243,7 @@ def get_item(self, id):
 
 class CommentHandler(ItemHandler):
   def get_item(self, post_id, id):
-    post = self.get_post(post_id)
+    post = self.get_post(post_id, fetch_replies=True)
     cmt = self.source.get_comment(
       id, activity_id=post_id, activity_author_id=self.source.key.id(),
       activity=post)
@@ -256,7 +257,7 @@ def get_item(self, post_id, id):
 
 class LikeHandler(ItemHandler):
   def get_item(self, post_id, user_id):
-    post = self.get_post(post_id)
+    post = self.get_post(post_id, fetch_likes=True)
     like = self.source.get_like(self.source.key.string_id(), post_id, user_id,
                                 activity=post)
     if post:
@@ -294,7 +295,7 @@ def get_item(self, post_id, user_id, reaction_id):
 
 class RepostHandler(ItemHandler):
   def get_item(self, post_id, share_id):
-    post = self.get_post(post_id)
+    post = self.get_post(post_id, fetch_shares=True)
     repost = self.source.gr_source.get_share(
       self.source.key.string_id(), post_id, share_id, activity=post)
     # webmention receivers don't want to see their own post in their
