Repository navigation
fix(web): show unsupported-file toast and filter non-images in the collage tool - #2890
Merged
Merged
Conversation
snapotter-hq
force-pushed
the
claude/2863-fix
branch
from
October 21, 2026 05:34
dc85a66 to
af06b0d
Compare
…llage tool (snapotter-hq#2863) Closes snapotter-hq#2863 The collage upload area drop handler dropped non-image files silently, and the upload area click picker and the thumbnail strip add button passed whatever the file dialog returned straight to the store, so a text file picked there was added as a collage image. All three entry points now filter with isImageFile. When files were chosen or dropped but none are images, showUnsupportedFileType(t.dropzone.unsupportedFileType) is shown, the same as the other tool intake paths in tool-page.tsx. A mixed selection keeps the images and does not toast.
snapotter-hq
force-pushed
the
claude/2863-fix
branch
from
October 21, 2026 06:14
af06b0d to
568e0d4
Compare
Owner
|
Review findings disposition:
|
Owner
|
Thanks for fixing #2863, @drakeo338. Before merging, we exported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2863.
The collage tool's upload area and "add more" button passed picked or dropped files straight to the store, with no unsupported-file feedback (the dropzone shows a toast, collage did not). The change filters non-images in the file-picker paths and shows the existing unsupported-file toast when nothing usable was chosen. Added a test file covering all four paths.
Type of change
Checklist
pnpm test) (only the new test file was run: 4 passed)pnpm typecheck) (not run)Screenshots (if applicable)
None.