Skip to content

add the name_override directive to allow names to be programmatical…#811

Merged
johanneskoester merged 4 commits intosnakemake:masterfrom
nh13:feature/name-override
Dec 21, 2020
Merged

add the name_override directive to allow names to be programmatical…#811
johanneskoester merged 4 commits intosnakemake:masterfrom
nh13:feature/name-override

Conversation

@nh13
Copy link
Copy Markdown
Contributor

@nh13 nh13 commented Dec 18, 2020

…ly set

Copy link
Copy Markdown
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant idea! Just one thing.

some_var = 'generate_out'

rule:
name_override: some_var
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd just call this name:.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@nh13 nh13 force-pushed the feature/name-override branch from 0bdb8d6 to 99505ca Compare December 20, 2020 07:18
@nh13
Copy link
Copy Markdown
Contributor Author

nh13 commented Dec 20, 2020

@johanneskoester made it work with name instead of name_override :)

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit f634715 into snakemake:master Dec 21, 2020
@johanneskoester
Copy link
Copy Markdown
Contributor

Thank you so much!

@nh13 nh13 deleted the feature/name-override branch December 21, 2020 17:24
johanneskoester pushed a commit that referenced this pull request Dec 6, 2023
### Description

The `name` directive (#811) is super helpful but I felt it wasn't very
obvious in the docs. I added an example usage based on my own usage of
it as I think a lot of others use it in the same manner.

### QC
<!-- Make sure that you can tick the boxes below. -->

* [ ] The PR contains a test case for the changes or the changes are
already covered by an existing test case.
* [x] The documentation (`docs/`) is updated to reflect the changes or
this is not necessary (e.g. if the change does neither modify the
language nor the behavior or functionalities of Snakemake).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants